Scripts: Apply a consistent coding style#2582
Merged
hoffie merged 3 commits intojamulussoftware:masterfrom May 20, 2022
Merged
Conversation
hoffie
commented
Apr 6, 2022
Comment on lines
+17
to
+28
| declare -A LANGS | ||
| LANGS[de_DE]="German" | ||
| LANGS[fr_FR]="French" | ||
| LANGS[it_IT]="Italian" | ||
| LANGS[nl_NL]="Dutch" | ||
| LANGS[pl_PL]="Polish" | ||
| LANGS[pt_BR]="Portuguese Brazilian" | ||
| LANGS[pt_PT]="Portuguese European" | ||
| LANGS[sk_SK]="Slovak" | ||
| LANGS[es_ES]="Spanish" | ||
| LANGS[sv_SE]="Swedish" | ||
| LANGS[zh_CN]="Simplified Chinese" |
Member
Author
There was a problem hiding this comment.
This is a manual change (before running shfmt) as shfmt fails to handle the previous formatting properly (each shfmt increases the indentation...). I don't know of a way to selectively disable shfmt for specific lines similar to shellcheck or clang-format. Therefore, I've chosen a different array assignment syntax, although as it is more verbose.
Merged
5 tasks
ann0see
reviewed
Apr 7, 2022
ann0see
approved these changes
Apr 7, 2022
Member
|
@hoffie this PR needs to be rebased ;-) |
pljones
approved these changes
May 19, 2022
Member
|
Thanks. @hoffie This PR needs rebasing |
1 task
Member
|
@pljones This missed the mentioning of "scripts" in the Changelog |
Collaborator
|
I was wondering if this should be merged with 2547. |
Member
|
Maybe. The changelog is already way too big... |
Collaborator
|
Yeah - that's why I was asking for suggesting on what to merge... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
shfmtcan't handle properlyshfmt -w .(A CI check will be in a follow-up PR: hoffie@ci-check-shell-scripts)
CHANGELOG: Scripts: Applied a consistent coding style
Context: Fixes an issue?
Related: #2474
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready.
What is missing until this pull request can be merged?
Reviews.
Checklist