Refactoring: move src/res/translation to src/translation#2576
Merged
ann0see merged 1 commit intojamulussoftware:masterfrom Apr 16, 2022
Merged
Refactoring: move src/res/translation to src/translation#2576ann0see merged 1 commit intojamulussoftware:masterfrom
ann0see merged 1 commit intojamulussoftware:masterfrom
Conversation
ann0see
force-pushed
the
patch/moveTranslation
branch
from
de75a64 to
fe88bb6
Compare
This is done to find translation files quicker
ann0see
force-pushed
the
patch/moveTranslation
branch
from
fe88bb6 to
2368d03
Compare
Member
|
Sounds good to me. I agree that a folder called 'res' three levels deep wasn't a very intuitive place to find them in ;) |
ignotus666
approved these changes
Apr 13, 2022
hoffie
approved these changes
Apr 14, 2022
Member
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
I think this is an improvement. The implementation looks clean (grep doesn't show any matches for the old path).
softins
approved these changes
Apr 16, 2022
Member
softins
left a comment
softins
left a comment
There was a problem hiding this comment.
The changes look sensible, and CI is ok, so happy to approve.
I haven't done any tests myself, nor tried any of the built assets, due to lack of time.
Member
Author
|
I considered this save to merge – for me nothing broke. |
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Apr 17, 2022
This was referenced Jul 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done to find translation files quicker
Short description of changes
CHANGELOG: Refactoring: Move translation files one level up to make finding them easier for translators.
Context: Fixes an issue?
Mentioned by me in chat. The deeply nested files have annoyed me for quite some time.
Does this change need documentation? What needs to be documented and how?
Yes. Contributors/especially Translators should be notified.
Status of this Pull Request
Discussion ready. Maybe another level/folder would be better?
What is missing until this pull request can be merged?
Review
Checklist