Stop the build if the audio SDK is missing#2536
Merged
ann0see merged 1 commit intojamulussoftware:masterfrom Mar 23, 2022
Merged
Stop the build if the audio SDK is missing#2536ann0see merged 1 commit intojamulussoftware:masterfrom
ann0see merged 1 commit intojamulussoftware:masterfrom
Conversation
hoffie
approved these changes
Mar 23, 2022
pljones
force-pushed
the
bugfix/fail-on-missing-build-artifacts
branch
from
2cd3e91 to
3cb05d7
Compare
pljones
requested review from
a team and
softins
and removed request for
a team
softins
approved these changes
Mar 23, 2022
Member
softins
left a comment
softins
left a comment
There was a problem hiding this comment.
Not tested, but looks good to me.
ann0see
approved these changes
Mar 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Stop the build if the audio SDK is missing
CHANGELOG: Stop the build if the audio SDK is missing
Context: Fixes an issue?
See #2525 (comment)
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Hopefully doesn't break the build when it should work. WFM...
What is missing until this pull request can be merged?
Could do with others testing the other configurations (I don't have 32bit Windows or build 32bit on 64bit).
Checklist