Move entitlements file to mac folder#2529
Conversation
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
Code looks good, an actual signing test should be run (no signing has been tested after the autobuild refactoring either...).
|
@emlynmac coukd you please git checkout my repo and push a signed beta/nightly with these changes? |
ann0see
force-pushed
the
patch/moveEntitlements
branch
2 times, most recently
from
b2df90d to
33dd49c
Compare
ann0see
force-pushed
the
patch/moveEntitlements
branch
2 times, most recently
from
0351261 to
75ccadc
Compare
|
Except for the infinitly long running builds on emlyn's fork, I think this is ok. |
So to be clear, master branch no longer builds on my fork. It is consistently hanging on the build macOS stage, so whatever changes broke the signing step, it is not in this PR. |
|
Yes. I know. I'll try to run CodeQl on the legacy build instead... |
See chat -- I ran a non-CodeQL master build with signing on @emlynmac's branch and it worked: https://github.com/emlynmac/jamulus/actions/runs/2054387680 |
|
@emlynmac I‘m going to merge this now. You‘ll probably need to fix conflicts |
4 participants
Short description of changes
Moves the Jamulus.entitlements file to the mac/ folder to clean up the root folder
CHANGELOG: Internal: Moved entitlements file to mac/ folder to clean up the repo root.
Context: Fixes an issue?
No. Clean up only.
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Should be tested by @emlynmac if it still builds correctly. Also it reminds me of the sandbox writing issue (https://developer.apple.com/forums/thread/666634)
What is missing until this pull request can be merged?
Needs testing - especially with a signed build.
Checklist