Rename define to JACK_ON_WINDOWS#2525
Conversation
| @@ -107,7 +107,7 @@ win32 { | |||
| HEADERS += linux/sound.h | |||
There was a problem hiding this comment.
Should line 104 stop the build? It's not going to work, after all...
There was a problem hiding this comment.
Mm, I'll do that in another PR.
There was a problem hiding this comment.
Just open an issue to let you remember :-)
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
Yep, that's certainly better than before.
In general, I was thinking whether linux/ should be renamed to jack/ (or at least parts of it? haven't checked). It's really strange to add linux/ on Windows or Mac builds.
I'm also wondering whether JACK_REPLACES_ASIO/JACK_ON_WINDOWS/JACK_ON_MAC could go away at some point (after all, there's WITH_JACK and there are defines for the actual platform as well, so I don't see the point of having one extra define for JACK on each platform).
All of that exceeds the scope of this PR though, so just adding this here as a comment.
cc @henkdegroot who last touched the JACK autobuild logic at least (although not directly related to the actual code parts).
| @@ -107,7 +107,7 @@ win32 { | |||
| HEADERS += linux/sound.h | |||
|
Merged since it's a trivial change. |
3 participants
Short description of changes
Renames a define.
CHANGELOG: Rename existing define to JACK_ON_WINDOWS
Context: Fixes an issue?
Renames a define. Makes it consistent with the CONFIG option.
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready.
What is missing until this pull request can be merged?
Ready.
Checklist