Improve code style in deploy_linux.sh#2510
Closed
ann0see wants to merge 1 commit intojamulussoftware:masterfrom
Closed
Improve code style in deploy_linux.sh#2510ann0see wants to merge 1 commit intojamulussoftware:masterfrom
ann0see wants to merge 1 commit intojamulussoftware:masterfrom
Conversation
ann0see
commented
Mar 14, 2022
Member
Author
|
Closed as it makes sense to delete this script (it's no longer in use) |
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Mar 15, 2022
The deploy_linux.sh file has not been in use since we moved over to debian building. Users who still use the source can use git or manually execute make dist. Related to: jamulussoftware#2510 (comment)
5 tasks
ann0see
added a commit
to ann0see/jamulus
that referenced
this pull request
Mar 15, 2022
The deploy_linux.sh file has not been in use since we moved over to building binaries (.deb). Users who still depend on compiling from source can use git, the GitHub source code release or manually execute make dist on a git clone. Related to: jamulussoftware#2510 (comment)
pgScorpio
pushed a commit
to pgScorpio/jamulus
that referenced
this pull request
Mar 28, 2022
The deploy_linux.sh file has not been in use since we moved over to building binaries (.deb). Users who still depend on compiling from source can use git, the GitHub source code release or manually execute make dist on a git clone. Related to: jamulussoftware#2510 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Smaller additions/modifications to deploy_linux.sh (also based on spellcheck proposals). Now the script needs to be run from the repo-root (similar to some other scripts).
CHANGELOG: SKIP
Context: Fixes an issue?
No. Just a few less warnings if we include spell-check in our CI.
Does this change need documentation? What needs to be documented and how?
No. I don't think it's even ChangeLog worthy since it could be added to the refactoring step
Status of this Pull Request
Working implementation
What is missing until this pull request can be merged?
Checklist