Autobuild: Combine and simplify Windows build scripts#2502
Autobuild: Combine and simplify Windows build scripts#2502ann0see merged 2 commits intojamulussoftware:masterfrom
Conversation
ann0see
left a comment
There was a problem hiding this comment.
I'd still be more happy if we let it in a windows specific folder for now. Maybe in future, we need to add other files like documentation?
980caee to
0598dae
Compare
|
I can't find the JACK build artifact of this run. Maybe there's a naming clash? |
0598dae to
97f9d59
Compare
Thanks for the pointer. Build step three lacked the necessary |
97f9d59 to
a1d2b51
Compare
That fixed it. In addition, I've checked the resulting Jamulus.exe files for JACK references (and lack thereof) -- all good. |
|
Great! It works now. |
Co-authored-by: ann0see <[email protected]>
a1d2b51 to
cdd2a4b
Compare
| echo "Copying artifact to ${artifact_deploy_filename}" | ||
| cp ".\deploy\Jamulus*installer-win.exe" ".\deploy\${artifact_deploy_filename}" |
There was a problem hiding this comment.
Maybe the deploy script could be adapted to create the correct name (but that's for another PR)
cdd2a4b to
f3ef254
Compare
Related: jamulussoftware#2503 - Move all autobuild/windows/* scripts to a single .github/autobuild/windows.ps1 script which is called for the different stages (setup/build/get-artifacts). - Condense redundant parameter parsing into a single step - Simplify jack build naming - Create functions with proper names for larger steps - Inline Github artifact output definition as it's shorter that way - Make coding style more consistent (spaces, curly braces)
f3ef254 to
da1b741
Compare
Short description of changes
CHANGELOG: Autobuild: Refactored and simplified Windows build scripts.
(will be condensed...)
Notes:
command:entry for each platform). I will also drop a number of unneeded commands (GITHUB_WORKSPACE extra logic).Context: Fixes an issue?
#2282 (reply in thread)
Related: #2503
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist