Improve build logic for JACK-related builds & warn about ASIO#2443
Merged
ann0see merged 4 commits intojamulussoftware:masterfrom Mar 2, 2022
Merged
Improve build logic for JACK-related builds & warn about ASIO#2443ann0see merged 4 commits intojamulussoftware:masterfrom
ann0see merged 4 commits intojamulussoftware:masterfrom
Conversation
pljones
reviewed
Mar 2, 2022
Also ensure (for license reasons) that we don't include ASIO headers on JACK builds. Related: jamulussoftware#2417
hoffie
force-pushed
the
jack-asio-improvements
branch
from
e1c9fa8 to
364716a
Compare
pljones
approved these changes
Mar 2, 2022
Collaborator
pljones
left a comment
pljones
left a comment
There was a problem hiding this comment.
Thanks - hoping for a green build...
ann0see
approved these changes
Mar 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
CHANGELOG: Internal: Refactored JACK- and ASIO-related build logic.
Context: Fixes an issue?
Related: #2417
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
What is missing until this pull request can be merged?
Reviews.
Checklist