Remove unneeded dependencies for Android build#2394
Merged
ann0see merged 1 commit intojamulussoftware:masterfrom Feb 23, 2022
Merged
Remove unneeded dependencies for Android build#2394ann0see merged 1 commit intojamulussoftware:masterfrom
ann0see merged 1 commit intojamulussoftware:masterfrom
Conversation
pljones
approved these changes
Feb 16, 2022
Collaborator
pljones
left a comment
pljones
left a comment
There was a problem hiding this comment.
Nice. And the build stayed green.
Collaborator
|
@jamulussoftware/maindevelopers Anyone else available to check this? |
hoffie
approved these changes
Feb 23, 2022
Member
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
Code looks good, app starts fine on Android 10 (Moto G4 Play, LineageOS).
Thanks!
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Remove potentially unneeded dependencies for android build
Context: Fixes an issue?
Related to #2379
Does this change need documentation? What needs to be documented and how?
No
CHANGELOG: Android: Remove unneeded dependencies to speed up build
Status of this Pull Request
Needs installation check on Android. Does everything work?
Especially config file (seems to work so so. See #1382 (comment)), connection to servers (works),...
What is missing until this pull request can be merged?
Testing on a real android machine. This is the .apk my local docker container produced: https://github.com/ann0see/jamulus/releases/download/latest/jamulus-build-local-android.zip (done on LinageOS)
Checklist