Update de_DE app translation for 3.8.2#2349
Merged
ann0see merged 4 commits intojamulussoftware:masterfrom Feb 8, 2022
Merged
Conversation
ann0see
commented
Feb 5, 2022
hoffie
reviewed
Feb 5, 2022
Member
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
Thanks a lot for doing this! I can only imagine how tedious the translation stuff is.
Co-authored-by: Christian Hoffmann <[email protected]>
ann0see
force-pushed
the
translate/de_3.8.2
branch
from
14b08e3 to
f8c9eed
Compare
Member
Author
|
ann0see
commented
Feb 6, 2022
| <location filename="../../clientdlg.cpp" line="207"/> | ||
| <source>If this LED indicator turns red, you will not have much fun using the %1 software.</source> | ||
| <translation type="unfinished"></translation> | ||
| <translation>Wenn diese LED rot leuchtet, dann wirst du wenig Spaß mit der %1 Software haben.</translation> |
Member
Author
There was a problem hiding this comment.
Suggested change
| <translation>Wenn diese LED rot leuchtet, dann wirst du wenig Spaß mit der %1 Software haben.</translation> | |
| <translation>Wenn diese LED rot leuchtet, dann wirst du wenig Spaß mit %1 haben.</translation> |
Member
Author
|
Hopefully my last self review ;-). If these changes are ok. I think it's ready. |
Contributor
|
Hi @ ann0see ,
If my help is still needed I can review the translation until tomorrow (monday) evening. Otherwise I'll be happy to participate again next time.
Regards
rolamos
… Am 06.02.2022 um 20:52 schrieb ann0see ***@***.***>:
Hopefully my last self review ;-). If these changes are ok. I think it's ready.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Member
Author
|
Hi @rolamos Yes, please review this PR. |
rolamos
reviewed
Feb 7, 2022
Contributor
rolamos
left a comment
rolamos
left a comment
There was a problem hiding this comment.
Reviewed the German translation... made a few suggestions for minor changes
Member
Author
|
Thank you very much for your review! |
Co-authored-by: Roland Moschel <[email protected]>
rolamos
approved these changes
Feb 7, 2022
Co-authored-by: Christian Hoffmann <[email protected]>
Member
Author
|
Ok. Should be squash-merged. @pljones can you please cross-review? |
Member
Author
|
Ok. Force merged since we do have 2 approving reviews |
hoffie
changed the title
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
Feb 13, 2022
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
Feb 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is just a one time translation to get a bit used to how the translation works. I don't want to replace the German translation team.
Short description of changes
Adds Translation for 3.8.2. Was a quick round, so I'd be happy about reviews. I'm not familiar with the translation process, so there might be inconsistencies introduced by this PR. @rolamos I would be happy about a review.
Context: Fixes an issue?
Fixes: #2301
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Untested, needs review
What is missing until this pull request can be merged?
Review by some translator.
Checklist