Add MIDI control option for Mute Myself function#2334
Add MIDI control option for Mute Myself function#2334softins merged 1 commit intojamulussoftware:masterfrom
Conversation
henkdegroot
changed the title
| // in case of a headless client the buttons are not displayed so we need | ||
| // to send the controller information directly to the server | ||
| #ifdef HEADLESS | ||
| // FIXME: no idea what to do here. |
There was a problem hiding this comment.
Basically, follow the path.
What the emit does is handled somewhere - that method ends up back in the client code and should be what's called here.
There should really be no client.cpp code that's dependent upon the state of #ifdef HEADLESS - the client should work the same regardless.
Currently it goes to src/clientdlg.h line 150 to check the toggle the box in the dialog, which then triggers the dialog to emit the change, which the client handles.
This does ensure the UI is consistent with the client state, but it's not the right way to do it.
pljones
left a comment
pljones
left a comment
There was a problem hiding this comment.
Looks like it's consistent with the existing way of working.
I've not tested it myself (as I can't get Jack working on Windows since Windows 7 came out).
|
I can't get this to work. Tried the .deb from @henkdegroot's repo and also compiling his branch from source. Tested on Linux Mint 20.2 with JACK. This is my command:
Maybe I'm doing something obvious wrong? The other commands work as normal. |
If you took the one from my repo (autobuild), then the option might be the letter u instead of o. |
|
Just to be sure - I'm testing the build from here. Still won't work :( Tried 'u', 'o', other MIDI CC values, altering the order of the ctrlmidich parameters... I'm using MIDImonitor in parallel to make sure the right MIDI messages are sent. All the other parameters work... |
Okay that should be the correct one and use the letter o. I have tested with Ubuntu 20 and also on Windows 10 and Windows 11. Now reading your command a bit more careful and I notice it cannot be correct like this.
As for o you are using CC # 3. However for m you start with CC # 2 (* 8), so CC # 2,3,4,5,6,7,8,9 are used for the "client mute". |
|
Argh, you're absolutely right! Sorry for being such an ass :) I set the values properly so they didn't overlap and now it's working. Nice work! |
softins
left a comment
softins
left a comment
There was a problem hiding this comment.
Looks good to me, and tidily done.
|
Just to note, this is now to wait until 3.9.0 - reminder NOT to merge :) |
Just wondering, as we are making a few other small changes to the code, and this one is small, benign and useful to some, whether we could justify putting it in before 3.8.2rc1? It doesn't need any app translation. |
|
It would need documenting on the website though to be useful to anyone who hasn't followed this PR. I could do EN and ES, I don't know if the others (NL and FR at least) would mind doing a quick update - @jujudusud, @henkdegroot ? |
|
Don't mind doing that minor update at all. |
|
@ignotus666 , actually skiing the french alps. :-) |
|
I can do this on Monday; possibly tomorrow, but can't promise anything. Shall we go ahead and let FR catch up later? Or is the release imminent already? Either way, I suppose there's no harm in letting this feature go in now. |
|
I think it's ok to merge and I'm not worried about translations. As far as I understand, this is a feature extension, so the lack of translation simply means that the extension (new feature) is harder to use. But that can be fixed in a later (website translation) iteration, IMO. CHANGELOG: Client: Added MIDI control option for Mute Myself function |
|
According to the timelines, it should still fit when FR is done shortly after 14th of Feb: Scheduled feature freeze / Start of translation process: 2022-01-27 |
|
Sorry if dumb q: does it work with the non-jack windooze version? |
|
Unfortunately not, but you can install the version with JACK support. You just need to install jack2 as well |
|
For more information on how to make it work: https://jamulus.io/kb/2022/02/01/Midi-Mixerboard-Control.html |
|
Thank you very much, @henkdegroot ! Very kind! |
8 participants
Short description of changes
This change add an option to allow the Mute Myself checkbox to be controlled via MIDI. The character to use in the --ctrlmidich option for this is: o. Followed by the CC#. For instance use: o87 to enable/disable the Mute Myself using CC# 87.
Context: Fixes an issue?
New feature/option discussed in #2322
Does this change need documentation? What needs to be documented and how?
Letter o (for own) needs to be added to the --ctrlmidich option details.
Status of this Pull Request
Ready for review
What is missing until this pull request can be merged?
Tested on Windows and Linux using JACK.
Checklist