Update pl_PL app translation for 3.8.2#2331
Conversation
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
Looks good by scanning through the translation ;-)
| <location filename="../../clientdlg.cpp" line="727"/> | ||
| <source>%1 Directory</source> | ||
| <translation type="unfinished"></translation> | ||
| <translation>%1 Serwer</translation> |
There was a problem hiding this comment.
Just to be sure: Server is not equivalent to directory.
| <location filename="../../serverdlg.cpp" line="127"/> | ||
| <source>Recording has been switched off, either by the UI checkbox or SIGUSR2 being received</source> | ||
| <translation type="unfinished"></translation> | ||
| <translation>Nagrywanie zostało wyłączone przez użytkownika lub otrzymano komunikat SIGUSR2</translation> |
| <location filename="../../serverdlg.cpp" line="148"/> | ||
| <source>Language</source> | ||
| <translation type="unfinished">Język</translation> | ||
| <translation>Język</translation> |
There was a problem hiding this comment.
| <translation>Język</translation> | |
| <translation>Język (Lang)</translation> |
I think @BLumia and I talked about adding (Lang) to the box to ensure people still understand it if the selected language is unknown
There was a problem hiding this comment.
I don't understand from where those 'unfinished' entries came. Either QtLinguist shows all done and text editor search finds none.
There was a problem hiding this comment.
Do you mean in @ann0see's comment above? That's just the diff. The red part shows what it looked like before your changes (= what has been removed), and the green part shows the new parts. So everything is fine. :)
@ann0see Would it make sense to solve this (lang) thing in the code instead of asking all translators to add it? Or would you only add it for translations which don't contain *Lang*?
There was a problem hiding this comment.
Probably adding it to the code would be good; however this would also show it in English then.
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
Looks good to me, thanks a lot!
- Translator listed in the src/util.cpp, optionally add link to PR or code
- Punctuation and spacing consistent.
- Signal words consistent (“ASIO”, “Buffer”)
- App translations: No untranslated strings (grep unfinished -5 src/res/translation/translation_$TRANSLATION*.ts)
- App translations: Only a single .ts file checked in (.qm in addition is also OK)
- Installer translations: Passes tools/check-wininstaller-translations.sh
Note: Should be squash-merged. Leaving the merge to @ann0see.
3 participants
Fixes #2306
Short description of changes
Context: Fixes an issue?
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist