Skip to content

Comments

Update ASIO SDK#1981

Merged
softins merged 1 commit intojamulussoftware:masterfrom
ann0see:bug/fix-asiosdk
Aug 30, 2021
Merged

Update ASIO SDK#1981
softins merged 1 commit intojamulussoftware:masterfrom
ann0see:bug/fix-asiosdk

Conversation

@ann0see
Copy link
Member

@ann0see ann0see commented Aug 27, 2021 •
edited
Loading

Short description of changes

Updates ASIO SDK.

Context: Fixes an issue?

Fixes: #1880 Probably the old SDK we used made autobuild fail

Does this change need documentation? What needs to be documented and how?

CHANGELOG: On Windows Jamulus now uses the latest ASIO SDK

Status of this Pull Request

Kind of finished. Still needs tests on windows (and a green CI).

What is missing until this pull request can be merged?
Installation on windows

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

pljones
pljones approved these changes Aug 28, 2021
View reviewed changes
Copy link
Collaborator

@pljones pljones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see it's the location of the SDK, not the "version". It'll move again one day, I'm sure.

@ann0see
Copy link
Member Author

ann0see commented Aug 29, 2021

Yes, it also is the version, but without functional changes as far as I understand (see changelog)

@pljones
Copy link
Collaborator

pljones commented Aug 29, 2021 •
edited
Loading

Oh yes - the date on the end confused me! Tsk, if you (Steinberg) put a version there, why add a date to the filename?!

I'll grab the build now and see if it works.

@pljones
Copy link
Collaborator

pljones commented Aug 29, 2021

I tried standalone via my ancient Echo Audio ASIO driver and ASIO4ALL. In this set up, all I can test is that it connects with a sensible ping and overall delay, which both seemed fine.

I also tested with Reaper ReaRoute, where I can confirm audio throughput.

I think you could merge this now.

@ann0see
Copy link
Member Author

ann0see commented Aug 29, 2021

Thanks. We’re still missing a 2nd review before this can be merged.

@softins ?

@ann0see ann0see requested a review from softins August 29, 2021 10:45
@ann0see ann0see mentioned this pull request Aug 29, 2021
Merged
5 tasks
@softins
Copy link
Member

softins commented Aug 29, 2021

Will have a look asap

softins
softins approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, and URL verified.

@softins softins merged commit b517847 into jamulussoftware:master Aug 30, 2021
@ann0see ann0see deleted the bug/fix-asiosdk branch August 31, 2021 18:17
@pljones pljones added this to the Release 3.8.1 milestone Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pljones pljones pljones approved these changes

@softins softins softins approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 3.8.1

Development

Successfully merging this pull request may close these issues.

New ASIO SDK available

3 participants

@ann0see @pljones @softins