Move ping/delay/jitter measurements from settings to main window by dcorson-ticino-com · Pull Request #1762 · jamulussoftware/jamulus

dcorson-ticino-com · 2021-05-26T13:59:17Z

The values are not updated on the cleintsettings tab.
I don't think this is too ugly, so it could be workable.
Please test to see if it no longer has memory loss.
The only problem I see is with the stream data rate which is now not
shown. I could imagine to use a static variable to store the last value
and only update when changed, which will be almost never.

I will start now to clean this up with the accessibility stuff, etc.
where it should be. Will not change the functioning.

The values are not updated on the cleintsettings tab. I don't think this is too ugly, so it could be workable. Please test to see if it no longer has memory loss. The only problem I see is with the stream data rate which is now not shown. I could imagine to use a static variable to store the last value and only update when changed, which will be almost never. I will start now to clean this up with the accessibility stuff, etc. where it should be. Will not change the functioning.

softins · 2021-05-26T14:27:32Z

You definitely need the stream rate displayed somewhere, and it makes sense to do that in the original place (just having the one line in the Measurements box), since it is only when changing audio quality or mono/stereo that it changes.

I have been running this PR under the same conditions as my earlier tests, and it does not ramp up the memory or CPU usage, so that is certainly an improvement. It also looks quite nice having the details on the screen like that.

softins · 2021-05-26T14:35:48Z

I've also tested running with the mixer window not on top:

With the settings window on top instead, and
With a non-Jamulus window on top.

In both cases, the memory and CPU usage remained stable. So it looks like this is the way to go. Just display the audio stream rate in the Settings window as before, and move the ping time, and overall delay to the main window as you have done.

ann0see · 2021-05-26T14:36:57Z

I'd say this is a good solution to the issue. (It might also close another issue I didn't look for yet)

I just noticed that the UI (mixing board) starts to move around while the Ding/Delay changes.

src/clientdlg.cpp

ann0see · 2021-05-26T14:57:20Z

Will you totally remove the Measurements box in settings or do you think we should still show the LEDs there?

softins · 2021-05-26T14:59:10Z

Will you totally remove the Measurements box in settings or do you think we should still show the LEDs there?

I don't think it needs to show the LEDs, but it does need to show the data rate, as that is not shown anywhere else, and doesn't change except when the user changes something.

ann0see · 2021-05-26T15:02:19Z

Yes. But I think we could still show the LEDs. We'd at least have some stats in the settings window.

softins · 2021-05-26T15:06:17Z

Yes. But I think we could still show the LEDs only to at least have some stats in the settings window.

But the LEDs still get updated when their status changes, and it's frequent updates in the settings window that potentially cause the issue (even though we've only seen it with setText() so far). I would be in favour of removing them, since the numbers they relate to are no longer there, and those LEDs are duplicating what is already shown in the main window.

ann0see · 2021-05-26T15:08:26Z

Yes. But they don't seem to produce the bug. Let's wait what others think.

WhatsThis etc. updated for new positions. Measurement values removed from settingsdlg Audio data rate back in settingsdlg

dcorson-ticino-com · 2021-05-26T15:43:30Z

I just pushed an update with corrections and cleaning up.
Personally I think the leds belong with the values, client or settings, one or the other, not both.
The data rate is back in the settings window, please test so we are sure we don't have the problem back again.

softins

This is a great improvement. But a few comments:

Need to make the value fields long enough to contain the largest value (e.g. 999) without varying in length. And make the fields of fixed length so they don't make the right-hand separator jump. I think this is what @ann0see mentioned.
There are some translation updates, e.g. "buffers" to "jitter buffers". We might want to revert to "buffers" until after the next release?
I wasn't able to make the "> 500ms" message appear. Will try again.

dcorson-ticino-com · 2021-05-26T16:41:24Z

This will have an effect on the translations in any case. The data stream was part of the same whatsthis text as the ping etc.
As they are no longer together I had to change them.

src/clientdlgbase.ui

hoffie · 2021-05-26T17:11:00Z

src/clientdlgbase.ui

 </tabstops>
 <resources>
-  <include location="resources.qrc"/>
+  <include location="../../jamulus3_8_0rc1/src/resources.qrc"/>


I have no explanation how that got in there. I checking to correct.

Those lines do not exist in my source.
I do not know what to do.
I have pushed again with small changes to the UI to assure the display of >500 etc.
I hope these errors are now gone.
BTW I checked the >500 display by changing the if comparison to 200, there are many servers with more than 200ms. But now it is back to 500.

I hope these errors are now gone.

Looks good!

(Not marking this as resolved yet as it contains a hint for @softins regarding the 500ms question above)

ann0see · 2021-05-26T15:42:25Z

src/clientdlg.cpp

+    lblDelay->setWhatsThis ( strConnStats );
+    lblDelayVal->setWhatsThis ( strConnStats );
+    ledDelay->setWhatsThis ( strConnStats );
+    ledDelay->setToolTip ( tr ( "If this LED indicator turns red, "


Not part of this PR, but we should use QString ( … %1 … ) .arg ( APP_NAME ); here

Not part of this PR, but we should use QString ( … %1 … ) .arg ( APP_NAME ); here

Yes, I agree. Just to re-iterate, this not only does not have to be part of this PR, it should not be part of this PR to avoid introducing even more translation movements.

henkdegroot · 2021-05-26T18:28:00Z

@dcorson-ticino-com would it make sense to update the Fancy LEDs as part of this change? In total 6 lines of codes you need to update and add two images (which you can take from my PR #1752)?
As all other items in that PR have been covered now by this update.

henkdegroot · 2021-05-26T18:30:03Z

This will have an effect on the translations in any case.

Will we do a translation update for this? Just noticed a "What is This?" dialog which now contains a mixture of English (not translated) and Dutch. Not too disturbing though....but just checking.

hoffie

Haven't looked at all details yet, just some thoughts:

Despite the technical necessity to avoid the memleak, I personally like the change as it'll allow me to keep the settings window closed.
I'm wondering if we should hide all the labels in disconnected state in order to avoid cluttering the UI for new users which haven't even connected (maybe in a follow up PR?).
As this PR "only" shifts UI elements around, no new translations should be necessary, right? Are there any manual .ts edits necessary to guarantee that? (Also wondering where the strangeness that @henkdegroot described comes from)
I'm a bit wary if this PR may just shift the problem from the settings window to the main window. @softins's tests seem to show that this is not the case. @pianojoe's initial bug report contained information that the main window may have a problem as well, so we should be extra sure that we don't make things worse by this change. Input from @pianojoe would be highly appreciated :)

softins · 2021-05-26T18:45:10Z

I'll look more and respond sometime tomorrow. I'm rather Jamulused-out this evening after 4 days solid.

from Henk's PR, thanks Henk !

dcorson-ticino-com · 2021-05-26T18:57:44Z

* As this PR "only" shifts UI elements around, no new translations should be necessary, right?

As I wrote above:
This will have an effect on the translations in any case. The data stream was part of the same whatsthis text as the ping etc.
As they are no longer together I had to change them.

henkdegroot · 2021-05-26T19:07:59Z

(Also wondering where the strangeness that @henkdegroot described comes from)

Let me double check....think this is caused by the fact that the qm files are not automatic updating in the deploy windows powershell...building now with updated qm to check.

Update: No still happenig with updated qm files. Believe this is an effect from changing Buffer to Jitter (and Jitter buffer) but for some odd reason I can also not locate the English text in the ts file. Guess no lupdate has been performed yet.
Update2: Well lupdate will add the string to the ts file, but won't make it Dutch :) No problem at moment for me.

- connect button expands to column width - jitter buffer whatsthis corrected

henkdegroot · 2021-05-27T20:56:53Z

@dcorson-ticino-com I noticed I can now make the settings dialog very narrow. Not sure if that is seen as being an issue or not.

About the connect button, think because the left side now expands due to different lenght of text, it became visible that the button does not expand with it. Think making it the same width as the left section would be good.

dcorson-ticino-com · 2021-05-27T21:01:16Z

@dcorson-ticino-com I noticed I can now make the settings dialog very narrow. Not sure if that is seen as being an issue or not.
About the connect button, think because the left side now expands due to different lenght of text, it became visible that the button does not expand with it. Think making it the same width as the left section would be good.

I just pushed a correction for the connect button. Please try it out.
Making the settings very narrow was a request a couple of weeks ago.

ann0see · 2021-05-27T21:08:48Z

Yes. Looks much better now! Thank you!

henkdegroot · 2021-05-27T21:13:53Z

Button looks good now indeed....I mean it now allows extreem narrow.....it was not like this the previous rc1 builds.

ann0see · 2021-05-27T21:15:03Z

Yes. But I think that's intended

hoffie

So, after having a closer look:

UI-wise, I'm happy
Code-wise, I'm mostly happy -- see minor nit wrt function naming (plus I only skimmed the .ui files)
This PR does more than the title says. It not only moves the measurements, it also changes other aspects (labels/texts, resize behavior [?]). In general, this would not be a problem and I consider all of these changes to be good. However, given that this is (hopefully) our rescue against memory leaks in RC1 phase, I'm keen on keeping such changes limited.
- The text changes invalidate translations (@softins hinted at earlier that as well). This raises new questions:
  1. Should we run another translation cycle? This will further delay the release. I'd really not do that.
  2. Should we accept that parts of the UI will be untranslated? It looks like this will "only" affect signal words (Ping, Jitter) which are likely to be translated verbatim anyway + What's this texts. So it may be acceptable to go this path.
  3. Should we revert the unnecessary updates here (or in a follow-up, 3.8.0-only PR)? Not sure if it's worth the effort...
- This affects 7 places (according to a grep '"unfinished"><' src/res/translation/translation_de_DE.ts -c comparison between master and this PR).
- In any case, I'd suggest not trying to stuff further improvements into this PR, even if they are welcome in general. :)
- @dcorson-ticino-com
  
  This will have an effect on the translations in any case. The data stream was part of the same whatsthis text as the ping etc. As they are no longer together I had to change them.
  
  I'm not sure about this part. While I think they had been part of the same concatenated string, they had been split into individual translations in the past as well. So it may be possible to retain the translation?

@jamulussoftware/maindevelopers What do you think?

In any case, @softins will probably have the final word here after another test run with the current PR state which has the data-rate label re-added.

Thanks for working on this @dcorson-ticino-com! :)

src/clientsettingsdlg.cpp

hoffie · 2021-05-27T21:42:37Z

src/clientsettingsdlg.cpp

-        lblOverallDelayValue->setText ( QString().setNum ( iOverallDelayMs ) );
-        lblOverallDelayUnit->setText ( "ms" );
-    }
+    // ping and delay times now in clientdlg


Not sure if this comment is really necessary? If a programmer is looking for the ping time, they can use grep or something. If a user is looking for it, they'll most likely not check the code. :)

hoffie · 2021-05-27T21:44:48Z

src/main.cpp

 #else
 #    if defined( Q_OS_IOS )
-    bUseGUI        = true;
+    bUseGUI = true;


Hrm, does clang-format format it that way? What version are you using? Mine (11.1.0) would revert that change again.

We comply with the version autobuild uses.

But, as it appears to be the only change to main.cpp - please revert. And clang-format objected.
See #1762 (comment)

hoffie · 2021-05-27T21:45:50Z

src/resources.qrc

-    </qresource>
-    <qresource prefix="/translations">
        <file alias="translation_fr">res/translation/translation_fr_FR.qm</file>
-    </qresource>
-    <qresource prefix="/translations">
        <file alias="translation_pt_PT">res/translation/translation_pt_PT.qm</file>
-    </qresource>
-    <qresource prefix="/translations">
        <file alias="translation_pt">res/translation/translation_pt_BR.qm</file>
-    </qresource>
-    <qresource prefix="/translations">
        <file alias="translation_es">res/translation/translation_es_ES.qm</file>
-    </qresource>
-    <qresource prefix="/translations">
        <file alias="translation_nl">res/translation/translation_nl_NL.qm</file>
-    </qresource>
-    <qresource prefix="/translations">
        <file alias="translation_it">res/translation/translation_it_IT.qm</file>
-    </qresource>
-    <qresource prefix="/translations">
        <file alias="translation_pl">res/translation/translation_pl_PL.qm</file>
-    </qresource>
-    <qresource prefix="/translations">
        <file alias="translation_sk">res/translation/translation_sk_SK.qm</file>
-    </qresource>
-    <qresource prefix="/translations">
        <file alias="translation_sv">res/translation/translation_sv_SE.qm</file>
    </qresource>
-


This seems to merge different XML nodes to a single one. This sounds ok to me as a layman, but I'm still wondering why that happens (assuming that Qt Creator did this)?

I'm wondering if some newer version of Qt Creator than the advised "newest" (4.11.0) did this. If so, please revert.

Hmm ????
I have never touched that file and am using the same version of Qt since the end of last year. Why it should suddenly decide to change something ????

I have never touched that file

You did:) .... when you added the two image files for the Fancy status LEDs with accessibility markers. Not sure if you did that manually or in Qt of course...

You can also fix it (and the clang-format errors) like this:

git reset HEAD~ git add (all the other files except src/main.cpp and src/server.h) git add -p src/resources.qrc (n to everything except the two new png files) git commit -m 'your commit message' git checkout -- src/resources.qrc src/main.cpp src/server.h

(then, of course, test a local build before git push --force)

I don't think there is a problem with this change. It just built happily on my Pi, and also on the Github CI. It is also more consistent with the sections for other resources.

hoffie · 2021-05-27T21:52:28Z

src/clientsettingsdlg.cpp

+    QString strConnStats = "<b>" + tr ( "Audio Upstream Rate" ) + ":</b> " +
+                           tr ( " depends on the current audio packet size and "


This part invalidates all translations, even if it may look nicer with the bold formatting.

Independent of that, it looks a bit strange to me. Should probably be Depends (uppercase, no leading space) in the polished version.

hoffie · 2021-05-27T21:53:33Z

src/clientdlg.cpp

    // buffers LED
-    QString strLEDBuffers = "<b>" + tr ( "Buffers Status LED" ) + ":</b> " +
-                            tr ( "The buffers status LED shows the current audio/streaming "
+    QString strLEDBuffers = "<b>" + tr ( "Local Jitter Buffer Status LED" ) + ":</b> " +
+                            tr ( "The local jitter buffer status LED shows the current audio/streaming "
                                 "status. If the light is red, the audio stream is interrupted. "
                                 "This is caused by one of the following problems:" ) +


Invalidates translations. :(

hoffie · 2021-05-27T21:53:51Z

src/clientdlg.cpp

    ledBuffers->setWhatsThis ( strLEDBuffers );

-    ledBuffers->setAccessibleName ( tr ( "Buffers status LED indicator" ) );
+    ledBuffers->setAccessibleName ( tr ( "Local Jitter Buffer status LED indicator" ) );


Invalidates translations. :(

hoffie · 2021-05-27T21:55:48Z

src/clientdlgbase.ui

+               <widget class="QLabel" name="lblBuffers">
                <property name="text">
-                 <string>Input</string>
+                 <string>Jitter</string>


New translation, probably ok because it's a special word which hopefully makes sense in most translations.

hoffie · 2021-05-27T21:57:16Z

src/clientdlgbase.ui

+              <item row="0" column="0">
+               <widget class="QLabel" name="lblPing">
+                <property name="text">
+                 <string>Ping</string>


New translation -- previous was called "Ping time". I guess it'd be ok if untranslated.

pljones · 2021-05-28T07:46:36Z

Option 1: Release 3.8.0 with the known error and working translations, to be followed shortly by 3.8.1 with the fix (and potentially broken translations).

Option 2: Release 3.8.0 with the fix and broken translations.

Option 3: Delay 3.8.0, include the fix and update the translations.

Personally, I'd go with 1 or 2. It depends on how the number of MacOS users compares with the number of translation users.

ann0see · 2021-05-28T08:17:34Z

I wouldn’t go with 1. This bug is already fixed and we shouldn’t ship broken software. Not having a translation isn’t that bad; having a bug is far worse.

pljones · 2021-05-28T16:16:30Z

Shipping with known, documented defects is perfectly acceptable -- if the impact is small. If the number of people who'd be affected severely adversely by the broken translations was large (which I doubt, to be honest - the area affected is small) and the number of people affected by the bug was small, I'd go with the bug. Conversely, and I tend to believe more likely, if the number affected by the bug is greater, then fixing becomes the priority. But if the number affected by the translations is large, delay becomes an option.

hoffie · 2021-05-28T18:26:45Z

Option 1: Release 3.8.0 with the known error and working translations, to be followed shortly by 3.8.1 with the fix (and potentially broken translations).

Option 2: Release 3.8.0 with the fix and broken translations.

Option 3: Delay 3.8.0, include the fix and update the translations.

I'd clearly prefer option 2.

My point was just that we could possibly limit the effect of broken translations even without doing another round of translations and delay. @softins did a very good job doing so in other places, but I suspect Tony's time budget is a bit taxed for this release... :)
Still, this is being extra-picky as the affected translations seem to only consist of signal words and What's this texts.

softins · 2021-05-28T18:35:46Z

I have some time to devote to this tomorrow (Sat), and possibly a bit later this evening too. I would prefer option 2 or if we can manage it, 2.5 :)

-Renamed SetPingTimeResult -> UpdateUploadRate. -Audio rate whatsthis text & added whatsthis to audio rate groupbox. -Removed superfluous comment.

pljones · 2021-05-29T08:51:54Z

src/clientdlg.cpp

        chbChat->setChecked ( true );
        chbChat->blockSignals ( false );
    }
+    if ( !pClient->IsRunning() )


Should be in CClientDlg::Disconnect()? (I can see you followed how CClientSettingsDlg worked - but it's different in CClientDlg as there's already a home for things like this.)

Good catch!
Copy paste is good, turning brain on is better :)

pljones · 2021-05-29T09:02:34Z

src/server.h

 protected:
    virtual void run();

-    bool     bRun;


Please revert this change. clang-format objected.
See #1762 (comment)

I did not change this.
If anything changed it, it was clang-format.

dcorson-ticino-com · 2021-05-29T09:35:49Z

There is a problem with the Clang-format compliance.
I ran the directory through clang-format before committing, the autobuild style check says it is not OK, however.
Has the definition been changed, how do I get the new definition in that case, rebase?

softins · 2021-05-29T10:25:05Z

@dcorson-ticino-com I see that this PR was raised from your master branch. You should never do that, for several reasons:

It will cause you later confusion in your master branch after the change has been merged, especially if it gets squashed, or modified by committers.
It prevents you from working on more than one feature at a time in a clean way.
It makes it more difficult for project maintainers to push a change to your PR if required.

When starting to work on a new feature or a bug fix, you should always:

Get your master up to date with the upstream master:
- git checkout master
- git fetch upstream
- git rebase upstream/master
- git push (now your local and origin masters match the upstream master)
Create a new branch for your changes:
- git checkout -b my-new-branch-name
Make all your changes on this branch. If you are also working on other unrelated changes, they can be in a different branch using the same technique, and you can switch between them easily.
Commit your changes to the branch:
- git status (make sure you are still on the expected branch)
- git add <files>... (or instead just do git commit -a on the next line)
- git commit (add the commit message)
If this branch has never been pushed before, do git push and it will tell you the full command to use, which you can copy and paste. Or just type it in:
- git push --set-upstream origin my-new-branch-name
If you are ready to raise a PR from it, you can do that at Github. If you have more to do, just make your new changes, commit as above, and do a simple git push to update Github.
If the PR has not yet been merged, you can push further commits to it as above. If it has been merged, any further changes should be in a new branch and a separate PR.
If anyone else pushes a change to your branch (e.g. a project maintainer), you need to fetch those changes:
- git checkout my-new-branch-name
- git pull
If, due to the passage of time, the upstream master gets significantly updated and you want to get your work-in-progress up to date, you need to rebase and force-push:
- git checkout master
- git fetch upstream
- git rebase upstream/master (if you keep your own master clean of changes, this will just fast-forward)
- git push (updates your origin master)
- git checkout my-new-branch-name (the one you are working on)
- git rebase master (get the latest upstream changes into your work-in-progress - you may need to handle conflicts)
- Once all conflicts are resolved and the result compiles and tests ok:
- git push --force

pljones · 2021-05-29T11:20:56Z

git rebase master

Following two weeks of misery at work, I now always recommend rebase -i over plain rebase, so you have some idea of what commits are going to be applied. If they are not only the ones from your branch, you're in for pain.

This reverts the affected texts back to the values that have already been translated, so we can release 3.8.0. The original improvements can be re-applied if required after the release.

softins

I think this is good to merge now. I will check the built Mac artifact when it becomes available, and will merge then, once it has a second approval.

hoffie

Thanks for the updates, @dcorson-ticino-com and @softins!
Approving now, but maybe @pljones can also indicate if the PR is acceptable for him now?

pljones · 2021-05-29T15:04:27Z

Is there another issue raised to cover reinstating the changed reverted? I'd like that done before things are lost...

I'd like the unnecessary part of the change to src/resources.qrc reverted - i.e. only the two new lines added.

All good to go other than that.

softins · 2021-05-29T15:12:48Z

Is there another issue raised to cover reinstating the changed reverted? I'd like that done before things are lost...

It's still in the commit history. I don't propose to squash merge. But I've raised an issue for 3.8.1 to keep it visible #1775

I'd like the unnecessary part of the change to src/resources.qrc reverted - i.e. only the two new lines added.

OK, done

softins linked an issue May 26, 2021 that may be closed by this pull request

CPU usage increases over time until the UI becomes unresponsive. [mac] #1643

Closed

ann0see reviewed May 26, 2021

View reviewed changes

src/clientdlg.cpp Outdated Show resolved Hide resolved

src/clientdlg.cpp Outdated Show resolved Hide resolved

softins added this to the Release 3.8.0 milestone May 26, 2021

ann0see reviewed May 26, 2021

View reviewed changes

src/clientdlg.cpp Outdated Show resolved Hide resolved

Measurements in clientdlg 2

290e4ce

WhatsThis etc. updated for new positions. Measurement values removed from settingsdlg Audio data rate back in settingsdlg

softins reviewed May 26, 2021

View reviewed changes

hoffie reviewed May 26, 2021

View reviewed changes

src/clientdlgbase.ui Outdated Show resolved Hide resolved

hoffie reviewed May 26, 2021

View reviewed changes

UI clean up

b30fd8c

henkdegroot mentioned this pull request May 26, 2021

Update unit of measure display in settings dialog #1755

Closed

ann0see reviewed May 26, 2021

View reviewed changes

hoffie reviewed May 26, 2021

View reviewed changes

hoffie linked an issue May 26, 2021 that may be closed by this pull request

Unit of measure displayed twice when ping exceeds 500ms #1753

Closed

Changed LEDs to fancy

2e0f762

from Henk's PR, thanks Henk !

Small corrections

6e0c4ed

- connect button expands to column width - jitter buffer whatsthis corrected

hoffie reviewed May 27, 2021

View reviewed changes

hoffie changed the title ~~Measurements placed on clientdlg~~ Move ping/delay/jitter measurements from settings to main window May 27, 2021

More clean up

08da823

-Renamed SetPingTimeResult -> UpdateUploadRate. -Audio rate whatsthis text & added whatsthis to audio rate groupbox. -Removed superfluous comment.

pljones reviewed May 29, 2021

View reviewed changes

softins added 3 commits May 29, 2021 14:01

Revert text changes for translations

cf99107

This reverts the affected texts back to the values that have already been translated, so we can release 3.8.0. The original improvements can be re-applied if required after the release.

Formatting for clang

d43532b

Move clearing of ping and delay to Disconnect()

0516eb4

softins approved these changes May 29, 2021

View reviewed changes

hoffie approved these changes May 29, 2021

View reviewed changes

softins mentioned this pull request May 29, 2021

Reinstate text changes reverted for 3.8.0 #1775

Closed

Revert unrelated changes

34f653b

softins merged commit 413c871 into jamulussoftware:master May 29, 2021

softins mentioned this pull request May 30, 2021

A couple of potential problems with CJamRecorder #1788

Closed

		QString strConnStats = "<b>" + tr ( "Audio Upstream Rate" ) + ":</b> " +
		tr ( " depends on the current audio packet size and "

Comments

Conversation

dcorson-ticino-com commented May 26, 2021

Uh oh!

softins commented May 26, 2021

Uh oh!

softins commented May 26, 2021

Uh oh!

ann0see commented May 26, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ann0see commented May 26, 2021

Uh oh!

softins commented May 26, 2021

Uh oh!

ann0see commented May 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

softins commented May 26, 2021

Uh oh!

ann0see commented May 26, 2021

Uh oh!

dcorson-ticino-com commented May 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

softins left a comment

Choose a reason for hiding this comment

Uh oh!

dcorson-ticino-com commented May 26, 2021

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dcorson-ticino-com May 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoffie May 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henkdegroot commented May 26, 2021

Uh oh!

henkdegroot commented May 26, 2021

Uh oh!

hoffie left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

softins commented May 26, 2021

Uh oh!

dcorson-ticino-com commented May 26, 2021

Uh oh!

henkdegroot commented May 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

henkdegroot commented May 27, 2021

Uh oh!

dcorson-ticino-com commented May 27, 2021

Uh oh!

ann0see commented May 27, 2021

Uh oh!

henkdegroot commented May 27, 2021

Uh oh!

ann0see commented May 27, 2021

Uh oh!

hoffie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ann0see commented May 26, 2021 •

edited

Loading

dcorson-ticino-com commented May 26, 2021 •

edited

Loading

dcorson-ticino-com May 26, 2021 •

edited

Loading

hoffie May 26, 2021 •

edited

Loading

hoffie left a comment •

edited

Loading

henkdegroot commented May 26, 2021 •

edited

Loading

pljones May 29, 2021 •

edited

Loading

pljones May 28, 2021 •

edited

Loading

pljones May 29, 2021 •

edited

Loading

ann0see commented May 28, 2021 •

edited

Loading

pljones commented May 28, 2021 •

edited

Loading

hoffie commented May 28, 2021 •

edited

Loading