Use exec when starting process via the shell.#1518
Use exec when starting process via the shell.#1518gilgongo merged 2 commits intojamulussoftware:masterfrom
Conversation
|
These commit messages are much better than in the other pull request - thumbs up. It is a question if we want to keep this option -o $(uname) though, the local hostname not being so relevant/helpful in many cases. |
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
For my taste, the commit message could use some more explanation about the "why". A textual comment ("This fixes signal handling"), a reference to #1515 or even both would be good.
Technically, this will be possible to look up by taking the merge commit's reference to this PR and following the description there. Having the context and intention available directly in git makes it easier when using git log, git blame or git bisect.
This fixes the signal handling issue with systemctl reported in jamulussoftware#1515, but still allows shell substitution of environment variables.
Uses anygenre3.jamulus.io as an example, because that server is less used.
|
Commit messages enhanced and force-pushed. |
Add exec as per jamulussoftware/jamulus#1518
|
You could use simply |
|
|
7 participants
This fixes the signal handling issue with systemctl reported in #1515,
but still allows shell substitution of environment variables.
Also changes use of
fischvolk.detojamulus.ioin examples.