Conversation
Move all client and server source compilation instructions to COMPILING.md. From now on, we assume binary installs, and further assume that people who choose to compile don’t need hand holding.
Add link to install scripts.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Update link
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
Thanks for doing this, it reads very clearly. I added comments about some details.
Co-authored-by: Christian Hoffmann <[email protected]>
Co-authored-by: Christian Hoffmann <[email protected]>
This comment has been minimized.
This comment has been minimized.
Remove stuff more relevant to packagers,
Lower case all deps.
This comment has been minimized.
This comment has been minimized.
Remove stuff that binary installs now cater for.
Remove unsafe reference to footnote on server install page.
Co-authored-by: ann0see <[email protected]>
This comment has been minimized.
This comment has been minimized.
Remove Qt4 line.
Add clarification re. build scripts. Fix code blocking,
Tidy up headless build reqs.
Damn code block formatting again.
Remove make clean
Remove make clean note
add distclean + explanation. Remove redundant Jamulus.pro
Put headless flag explanation first
Update preamble.
Add amends for Fedora 33 as per jamulussoftware/jamuluswebsite#428
Remove repetition. Co-authored-by: Christian Hoffmann <[email protected]>
Correct comment Co-authored-by: Christian Hoffmann <[email protected]>
Correct comment Co-authored-by: Christian Hoffmann <[email protected]>
Correct comment Co-authored-by: Christian Hoffmann <[email protected]>
Remove Rpi para
|
|
||
| ## macOS | ||
| You will need XCode and Qt as follows: | ||
|
|
There was a problem hiding this comment.
Sorry to be a pain on this... :) If we're moving off brew for the automation, should we move off it here, too? @softins
(I was also thinking if we should recommend aqtinstall generally for installing Qt, so these instructions mirror the autobuild more closely.)
There was a problem hiding this comment.
Yes, probably. We ought also work out how the user can get the correct SDK for compatibility with Qt5, as mentioned in #1655. I'm not an expert in Mac compiling - just feeling my way.
There was a problem hiding this comment.
Slightly out on a limb with this I realise, since I've moved all the compilation stuff into this file and out of the website, but the website links to this file - which isn't merged yet. What would happen if we merged this now? Would dat be a breaker?
There was a problem hiding this comment.
No. I don't think so. We could leave it as is.
Replace qt5-qtbase with libQt5Concurrent5 as per jamulussoftware/jamuluswebsite#440
This comment has been minimized.
This comment has been minimized.
Further Fedora dependency clarification
Clarify RPi OS.
jujudusud
left a comment
jujudusud
left a comment
There was a problem hiding this comment.
Think it's actual like that.
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
That's a small hacky way to do it, but I think it should work with the integrated GitHub suggestion button.
iOS instructions from @ngocdh Co-authored-by: ann0see <[email protected]>
ann0see
left a comment
ann0see
left a comment
There was a problem hiding this comment.
Just one small comment, afterwards it can be merged.
|
|
||
| ## macOS | ||
| You will need XCode and Qt as follows: | ||
|
|
There was a problem hiding this comment.
No. I don't think so. We could leave it as is.
Co-authored-by: ann0see <[email protected]>
ngocdh
left a comment
ngocdh
left a comment
There was a problem hiding this comment.
While we're at it, here's the instructions for Android, based on #1425 (comment) from @j-santander
- Install Qt, including the Android support from the Qt installer.
- Configure the Android settings in the Qt Creator (Tools -> Options -> Devices -> Android). Solve all warnings/errors in that dialog (set up paths to SDKs and NDKs and select the target for android, etc.). Tick on the "Automatically create kits for Android Toolk chains").
- Make sure the Android Kit is detected on Tools -> Options -> Kits -> Kits (example: Android Qt 5.15.2 Clang Multi-Abi). It should also show in the Qt Versions tab (example: Qt 5.15.2 for Android).
- Clone Jamulus and its submodules:
git clone https://github.com/jamulussoftware/jamulus.git
cd jamulus
git submodule update --init - Open Jamulus.pro in Qt Creator
- In the Projects tab -> Build & Run It should appear the Android Qt, might be disabled. Enabled it if it is not enabled.
- Then you can connect your device and build or run the project.
7 participants
Move all client and server source compilation instructions to COMPILING.md. From now on, we assume binary installs, and further assume that people who choose to compile don’t need hand holding.
This PR relies on the changes made to the Linux and Server install pages modified in jamulussoftware/jamuluswebsite#415
That PR is based on the following issues which will have to be manually closed when this PR closes because we have them in a separate repo.
See also jamulussoftware/jamuluswebsite#382 and jamulussoftware/jamuluswebsite#374