864-Windows-installer-issue-fix#1319
Conversation
ann0see
left a comment
There was a problem hiding this comment.
Thank you. I'll test it soon. See my comments which are just small hints.
eb20774 to
a57605f
Compare
|
Although it's not needed, but could you also please combine the installer and uninstaller fix into one commit and add "Fixes #864" into the commit description? |
There was a problem hiding this comment.
Built it in a path with one space (and also in one with multiple ones), and I can confirm it works now. Thank you very much for solving this issue. Hopefully there aren't any side effects from adding delims=?
Note to maintainers:
Line 441 in 3ef6950
|
@ann0see I checked the delims option and by not specifying a delimiter it ignores any. My first test was setting a specific delimiter but that would have introduced the same issue when that character is uses. |
a57605f to
1d8379f
Compare
I have combined into one commit now. Hoping I did it correct, first time I have done this. |
|
Yep. That's ok. You can add a description to every commit (not only a message description), but that's not needed. |
pljones
left a comment
There was a problem hiding this comment.
Approving untested -- the quoting does look very peculiar and c-n-p to a .bat file got a complaint before it got as far as expanding the variables. I'll take @ann0see's and @henkdegroot's word that it works in the NSI :)
|
Just merged it. Thank you again! You can add yourself as contributor here: Line 441 in fdd0f02 And could also open an issue on the documentation repo and state that the mentioning of the spaces issue can be removed from the compiling file. |
|
Just create my 2nd PR....to add myself to the contributors :) Will now create the issue on the documentation repo to get this updated. |
|
Thanks! |
Resolved the windows installer issue when space exists in the path