Skip to content

Comments

Changelog: Warn about ASIO4ALL setting migration, clarify bugfix#1282

Merged
gilgongo merged 1 commit intojamulussoftware:masterfrom
hoffie:changelog-3.7.0-asio
Mar 17, 2021
Merged

Changelog: Warn about ASIO4ALL setting migration, clarify bugfix#1282
gilgongo merged 1 commit intojamulussoftware:masterfrom
hoffie:changelog-3.7.0-asio

Conversation

@hoffie
Copy link
Member

@hoffie hoffie commented Mar 16, 2021

ChangeLog Outdated

- Bug fix: A crash when settings are changed in ASIO4ALL during a connection
has been fixed (#796).
- Bug fix: Deactivating selected input/outputs in ASIO4ALL now resets input-output channel mapping in Jamulus again (#796).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not just ASIO4ALL.

@ann0see ann0see self-requested a review March 17, 2021 08:26
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See pljones comment.

hoffie added a commit to hoffie/jamulus that referenced this pull request Mar 17, 2021
@hoffie hoffie requested a review from ann0see March 17, 2021 10:14
ChangeLog Outdated

- Bug fix: A crash when settings are changed in ASIO4ALL during a connection
has been fixed (#796).
- Bug fix: Changing ASIO driver properties like switching input/outputs in ASIO4ALL now resets input/output channel mapping in Jamulus again. This was done to solve a bug with ASIO4ALL introduced in the last version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference to #796 was dropped. Was that unintentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it was intentional. I've restored it now. Thanks.

BTW: I also unified line breaks. We had some long entries and we had wrapped entries. I unified it so that the first sentence ("header") of each entry is always on a single line.

Also place the first sentence of each entry completely on the first
line.

Co-authored-by: ann0see <[email protected]>
@hoffie hoffie force-pushed the changelog-3.7.0-asio branch from 926d439 to 9e02af7 Compare March 17, 2021 11:04
@hoffie hoffie requested a review from pljones March 17, 2021 11:50
Copy link
Member

@gilgongo gilgongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gilgongo gilgongo merged commit 065bfc1 into jamulussoftware:master Mar 17, 2021
@hoffie hoffie deleted the changelog-3.7.0-asio branch March 19, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants