Skip to content

Comments

Fix changing GUI style.#1267

Merged
ann0see merged 2 commits intojamulussoftware:masterfrom
softins:fix-gui-change-recording
Mar 15, 2021
Merged

Fix changing GUI style.#1267
ann0see merged 2 commits intojamulussoftware:masterfrom
softins:fix-gui-change-recording

Conversation

@softins
Copy link
Member

@softins softins commented Mar 15, 2021

The stylesheet on the main mixer board must be removed before applying
a global stylesheet to the GUI, and then reapplied afterwards.

Fixes #1238

@softins
Fix changing GUI style.
21f2327 
The stylesheet on the main mixer board must be removed before applying
a global stylesheet to the GUI, and then reapplied afterwards.
@ann0see
Copy link
Member

ann0see commented Mar 15, 2021

Thank you very much! I'll try it this afternoon/evening. After this and the ASIO4ALL copy thing #1260 is fixed, I'd tag the release!

@dcorson-ticino-com
Copy link
Contributor

dcorson-ticino-com commented Mar 15, 2021 •
edited
Loading

Thanks for finding this Tony !
Is the SetMixerBoardDeco routine still needed or can it be removed ?
Under Win10 your correction works without SetMixerBoardDeco.

So it appears that Debian does not replace the style sheet, but adds to it.
This was the behaviour that I had expected at the beginning, but learned making this change that Win10 replaces the style sheet and doesn't add to it.

@softins
Copy link
Member Author

softins commented Mar 15, 2021

Is the SetMixerBoardDeco routine still needed or can it be removed ?

Yes, it's still needed, to reapply the recording indication after changing GUI. Otherwise it stops being red.

@softins softins added this to the Release 3.7.0 milestone Mar 15, 2021
ann0see
ann0see approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it on my machine, and it fixes the bug. Thanks again!

@softins softins marked this pull request as draft March 15, 2021 13:03
@softins
Copy link
Member Author

softins commented Mar 15, 2021

There is a small issue on my pi with the title positioning. Just looking at it.

@softins
No need to set style sheet in UpdateTitle()
adb1716 
Already done in SetmixerBoardDeco() instead.
@softins
Copy link
Member Author

softins commented Mar 15, 2021

There is a small issue on my pi with the title positioning. Just looking at it.

The issue is identical in 3.6.2, so I don't think it is worth delaying the release for. It only occurs in Normal/Compact style.

@softins softins marked this pull request as ready for review March 15, 2021 16:08
@ann0see ann0see merged commit 4770be3 into jamulussoftware:master Mar 15, 2021
@softins softins deleted the fix-gui-change-recording branch March 15, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pljones pljones pljones approved these changes

@ann0see ann0see ann0see approved these changes

@hoffie hoffie Awaiting requested review from hoffie

+1 more reviewer

@dcorson-ticino-com dcorson-ticino-com dcorson-ticino-com approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Tracking
Status: Triage

Milestone

Release 3.7.0

Development

Successfully merging this pull request may close these issues.

Switching between skins causes mixing board to stay white

4 participants

@softins @ann0see @dcorson-ticino-com @pljones