Draft 3.7.0 release announcement [don't merge!]#1223
Draft 3.7.0 release announcement [don't merge!]#1223hoffie wants to merge 8 commits intojamulussoftware:masterfrom
Conversation
0bce5d0 to
48fa1a7
Compare
release-3.7.0-announcement.md
Outdated
|
|
||
| Thanks to everyone who did their part to make this release happen: | ||
| - Code contributors: @ann0see @atsampson @dakhubgit @dcorson-ticino-com @doloopuntil @dzpex @genesisproject2020 @hoffie @ignotus666 @jerogee @jujudusud @melcon @mulyaj @nefarius2001 @npostavs @passing @pljones @ranfdev @SeeLook @Snayler @softins | ||
| - Translators: @dzpex @genesisproject2020 @ignotus666 @jerogee @jose1711 @jujudusud @melcon @rolamos @SeeLook @Snayler @trebmuh |
There was a problem hiding this comment.
Actually there were/are more gegeweb who did parts of the french documentation for example.
There was a problem hiding this comment.
Then we should definitely add them. I generated the list from the list of app translation PRs. Do you have a quick way to get the additional people who did other translations such as docs?
There was a problem hiding this comment.
Maybe the contributor list on the doc repo.
There was a problem hiding this comment.
Ok, will check later. Maybe I can come up with some git log-based automation. Should be possible.
There was a problem hiding this comment.
There is also the contributors list in util.cpp, which we have tried to keep up to date and includes previous contributors.
There was a problem hiding this comment.
Turns out...
- It's a bit more than a one-liner. I'll add a PR for the
tools/directory shortly. - As my hand-generated list was based on PRs, I missed some people, even corrados!
I think the list in the announcement should be about the people who contributed to that release. This will be a subset of the util.cpp or Github contributor lists.
softins
left a comment
There was a problem hiding this comment.
No other specific comments. Great job!
based on tools/get_release_contributors.py
|
Todo: add note to add screenshot of ASIO4ALL settings since there is a big change with the installer. |
|
Concerning the changelog:
I‘m not 100% sure if we fully got this bug fixed. The bug I initially reported is fixed, but from time to time there still seems to be a freeze. That’s not a regression as far as I know |
Should we change the entry? If so, how? If a crash was fixed, I think it think the statement would continue to be true though? |
|
I'd change it to "Deactivating selected input/outputs in ASIO4ALL now resets input-output channel mapping in Jamulus again. This was done to solve a bug introduced in the last version." |
Is this only done for ASIO4ALL? If not, then the statement is misleading. |
|
No. It isn't.
|
Done: #1282
Done in this PR for the announcement and in #1282 (Changelog). |
|
Announcement has been posted: #1293 |
That's supposed to be the content which we post to Github discussions, Facebook, etc.
I'm opening this as a PR as it provides good ways to comment on specific parts. This is not supposed to be merged.
Things to check in reviews:
Download links will have to be verified when the release has been created (I'm just guessing URLs :)).