Skip to content

Comments

Draft 3.7.0 release announcement [don't merge!]#1223

Closed
hoffie wants to merge 8 commits intojamulussoftware:masterfrom
hoffie:3.7.0-announcement
Closed

Draft 3.7.0 release announcement [don't merge!]#1223
hoffie wants to merge 8 commits intojamulussoftware:masterfrom
hoffie:3.7.0-announcement

Conversation

@hoffie
Copy link
Member

@hoffie hoffie commented Mar 10, 2021

That's supposed to be the content which we post to Github discussions, Facebook, etc.

I'm opening this as a PR as it provides good ways to comment on specific parts. This is not supposed to be merged.

Things to check in reviews:

  • Is the content OK?
  • Are we missing any categories of contributors or specific people to mention?
  • Language (not a native speaker...)?

Download links will have to be verified when the release has been created (I'm just guessing URLs :)).

@hoffie hoffie added this to the Release 3.7.0 milestone Mar 10, 2021
@hoffie hoffie marked this pull request as draft March 10, 2021 21:29
@hoffie hoffie changed the title Draft 3.7.0 release announcement Draft 3.7.0 release announcement [don't merge!] Mar 10, 2021
@hoffie hoffie mentioned this pull request Mar 10, 2021
39 tasks
@hoffie hoffie force-pushed the 3.7.0-announcement branch from 0bce5d0 to 48fa1a7 Compare March 11, 2021 08:25
@hoffie hoffie requested review from ann0see, gilgongo and softins March 12, 2021 23:14

Thanks to everyone who did their part to make this release happen:
- Code contributors: @ann0see @atsampson @dakhubgit @dcorson-ticino-com @doloopuntil @dzpex @genesisproject2020 @hoffie @ignotus666 @jerogee @jujudusud @melcon @mulyaj @nefarius2001 @npostavs @passing @pljones @ranfdev @SeeLook @Snayler @softins
- Translators: @dzpex @genesisproject2020 @ignotus666 @jerogee @jose1711 @jujudusud @melcon @rolamos @SeeLook @Snayler @trebmuh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there were/are more gegeweb who did parts of the french documentation for example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we should definitely add them. I generated the list from the list of app translation PRs. Do you have a quick way to get the additional people who did other translations such as docs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the contributor list on the doc repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will check later. Maybe I can come up with some git log-based automation. Should be possible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also the contributors list in util.cpp, which we have tried to keep up to date and includes previous contributors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out...

  • It's a bit more than a one-liner. I'll add a PR for the tools/ directory shortly.
  • As my hand-generated list was based on PRs, I missed some people, even corrados!

I think the list in the announcement should be about the people who contributed to that release. This will be a subset of the util.cpp or Github contributor lists.

@ann0see @softins Can you re-check the list again now?

Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other specific comments. Great job!

@ann0see
Copy link
Member

ann0see commented Mar 15, 2021

Todo: add note to add screenshot of ASIO4ALL settings since there is a big change with the installer.

@ann0see
Copy link
Member

ann0see commented Mar 16, 2021

Concerning the changelog:

Bug fix: A crash when settings are changed in ASIO4ALL during a connection
has been fixed (#796).

I‘m not 100% sure if we fully got this bug fixed. The bug I initially reported is fixed, but from time to time there still seems to be a freeze. That’s not a regression as far as I know

@hoffie
Copy link
Member Author

hoffie commented Mar 16, 2021

Concerning the changelog:

Bug fix: A crash when settings are changed in ASIO4ALL during a connection
has been fixed (#796).

I‘m not 100% sure if we fully got this bug fixed. The bug I initially reported is fixed, but from time to time there still seems to be a freeze. That’s not a regression as far as I know

Should we change the entry? If so, how? If a crash was fixed, I think it think the statement would continue to be true though?

@ann0see
Copy link
Member

ann0see commented Mar 16, 2021

I'd change it to "Deactivating selected input/outputs in ASIO4ALL now resets input-output channel mapping in Jamulus again. This was done to solve a bug introduced in the last version."

@pljones
Copy link
Collaborator

pljones commented Mar 16, 2021

I'd change it to "Deactivating selected input/outputs in ASIO4ALL now resets input-output channel mapping in Jamulus again. This was done to solve a bug introduced in the last version."

Is this only done for ASIO4ALL? If not, then the statement is misleading.

@ann0see
Copy link
Member

ann0see commented Mar 16, 2021

No. It isn't.

Changing ASIO driver properties like changing input/outputs in ASIO4ALL now resets input-output channel mapping in Jamulus again. This was done to solve a bug with ASIO4ALL introduced in the last version.

@hoffie
Copy link
Member Author

hoffie commented Mar 16, 2021

I'd change it to "Deactivating selected input/outputs in ASIO4ALL now resets input-output channel mapping in Jamulus again. This was done to solve a bug introduced in the last version."

Done: #1282

Todo: add note to add screenshot of ASIO4ALL settings since there is a big change with the installer.

Done in this PR for the announcement and in #1282 (Changelog).

@hoffie
Copy link
Member Author

hoffie commented Mar 17, 2021

Announcement has been posted: #1293
As this PR is not supposed to be merged, I'm closing it.

@hoffie hoffie closed this Mar 17, 2021
@hoffie hoffie deleted the 3.7.0-announcement branch March 19, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants