Update pt_PT translation#1168
Merged
softins merged 1 commit intojamulussoftware:masterfrom Mar 3, 2021
Snayler:master
Merged
Conversation
hoffie
approved these changes
Mar 3, 2021
Member
There was a problem hiding this comment.
Thank you very much for your work! Looks good to me.
- Translator listed in the
src/util.cppLine 498 in 466c76e
- Punctuation and spacing consistent
- Signal words consistent ("ASIO", "Buffer")
- No untranslated strings (
grep unfinished -5 src/res/translation/translation_$TRANSLTION*.ts) - Only a single
.tsfile checked in (+.qm which is known to be not a problem)
Contributor
Author
So no need for the .qm file next file I do the translations? |
Member
As far as I understand: Yes, there's no need for you to check that in all required files will be generated as part of the release process. :) |
softins
approved these changes
Mar 3, 2021
Member
softins
left a comment
softins
left a comment
There was a problem hiding this comment.
Looks good to me. I couldn't find any conflicting accelerator keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.