Avoid conflicting accelerator keys.#1165
Merged
softins merged 1 commit intojamulussoftware:masterfrom Mar 3, 2021
Merged
Conversation
Member
Author
|
Just to clarify: I ran the GUIs in each language to verify which duplicates were actual conflicts and identify available keys. |
pljones
approved these changes
Mar 3, 2021
hoffie
approved these changes
Mar 3, 2021
Member
hoffie
left a comment
hoffie
left a comment
There was a problem hiding this comment.
@softins Thanks a lot for doing this! This sounds like a lot of manual work, even when script-assisted.
I verified that this PR only changes accelator keys and leaves everything else untouched:
diff -u0 <(git show | grep -P '^\+ ' | sed -re 's/&//; s/&//; s/^\+//' | sort) <(git show | grep -P '^- ' | sed -re 's/&//; s/&//; s/^-//' | sort)
I have not verified uniqueness of the keys again. It can only get better :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1161, but might need to be revisited for pt_PT and sk_SK when we have received complete translations.