Skip to content

Comments

Updated Spanish translation#1152

Merged
ann0see merged 5 commits intojamulussoftware:masterfrom
ignotus666:master
Mar 3, 2021
Merged

Updated Spanish translation#1152
ann0see merged 5 commits intojamulussoftware:masterfrom
ignotus666:master

Conversation

@ignotus666
Copy link
Member

No description provided.

@ann0see ann0see mentioned this pull request Mar 1, 2021
39 tasks
@ann0see ann0see added this to the Release 3.7.0 milestone Mar 1, 2021
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. See my comment

@ann0see
Copy link
Member

ann0see commented Mar 2, 2021

Not sure if you already know that you can translate the new Windows installer too: https://github.com/jamulussoftware/jamulus/pull/1124/files

@ann0see
Copy link
Member

ann0see commented Mar 2, 2021

I'll just post the official checklist here:

I think everything should be ok, but anybody who wants can check it.

  • Translator listed in the src/util.cpp
    "<p>Daryl Hanlon (<a href=\"https://github.com/ignotus666\">ignotus666</a>)</p>"
  • Looks consistent
  • Passes tools/check-wininstaller-translations.sh

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be good to me. I'll go through the checklist soon. Sorry for the late review.

@ann0see ann0see requested a review from hoffie March 2, 2021 20:59
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

Adding the non-installer checklist as well.

  • Translator listed in the src/util.cpp optionally add link to PR or code
  • Punctuation and spacing consistent
  • Signal words consistent ("ASIO", "Buffer")
  • No untranslated strings (grep unfinished -5 src/res/translation/translation_$TRANSLTION*.ts)
  • Only a single .ts file checked in (+ Installer translations)

Not merging yet to give @ignotus666 a chance to check the installer artifact maybe?

@ann0see ann0see merged commit 857cb98 into jamulussoftware:master Mar 3, 2021
@ann0see
Copy link
Member

ann0see commented Mar 3, 2021

@ignotus666 you might need to force push on your Repo to get to the same state as this one since I Squash & merged your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants