Skip to content

Comments

Update pt_BR translation for 3.7.0 (see jamulussoftware#1086)#1141

Merged
ann0see merged 2 commits intojamulussoftware:masterfrom
melcon:master
Mar 1, 2021
Merged

Update pt_BR translation for 3.7.0 (see jamulussoftware#1086)#1141
ann0see merged 2 commits intojamulussoftware:masterfrom
melcon:master

Conversation

@melcon
Copy link
Contributor

@melcon melcon commented Feb 27, 2021

No description provided.

@hoffie hoffie mentioned this pull request Feb 27, 2021
39 tasks
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your work!

  • Listed in the Contributors UI window
    "<p>Melcon Moraes (<a href=\"https://github.com/melcon\">melcon</a>)</p>"
  • Changes look consistent
  • No untranslated strings (except the copyright, which is fine I'd say)

@hoffie hoffie added this to the Release 3.7.0 milestone Feb 27, 2021
@hoffie hoffie requested a review from ann0see February 27, 2021 22:07
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me too. I'd remove the comments concerning the https:// question since I doubt the tool tip is clickable

Removing translator comments regarding https:// prefix on tooltip
@ann0see ann0see self-requested a review March 1, 2021 11:17
@ann0see ann0see merged commit 8614347 into jamulussoftware:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

3 participants