Skip to content

Comments

Create fr.nsi#1125

Merged
hoffie merged 6 commits intojamulussoftware:masterfrom
jujudusud:patch-2
Feb 27, 2021
Merged

Create fr.nsi#1125
hoffie merged 6 commits intojamulussoftware:masterfrom
jujudusud:patch-2

Conversation

@jujudusud
Copy link
Member

Creating the french translation of windows installer.

Creating the french translation of windows installer.
Adding French macro.
Adding Asio anchor.
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks.

updating with ${LANG_FRENCH}
@ann0see ann0see self-requested a review February 26, 2021 21:56
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. There's still a mistake I didn’t see at first here.

Deleting droit spaces between $ and {APPNAME}.
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to look good.

@ann0see ann0see added this to the Release 3.7.0 milestone Feb 27, 2021
@jujudusud
Copy link
Member Author

Thanks a lot @ann0see for your reviews and your help ! :-)

@ann0see ann0see requested review from a team and removed request for a team February 27, 2021 17:04
@hoffie hoffie mentioned this pull request Feb 27, 2021
39 tasks
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your work!

  • Translator listed in the src/util.cpp #1128
  • Looks consistent
  • Passes tools/check-wininstaller-translations.sh

@hoffie hoffie merged commit b3dd660 into jamulussoftware:master Feb 27, 2021
@trebmuh
Copy link
Member

trebmuh commented Mar 6, 2021

nice

@jujudusud jujudusud deleted the patch-2 branch March 6, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

4 participants