Polish translation of Windows installer NSIS script#1124
Polish translation of Windows installer NSIS script#1124ann0see merged 4 commits intojamulussoftware:masterfrom SeeLook:fix-for-installerlng
Conversation
ann0see
left a comment
There was a problem hiding this comment.
To make it work, you'll need to edit the installerlng.nsi file too.
|
Thanks for this BTW! |
ann0see
left a comment
There was a problem hiding this comment.
Can you check the artifact from the checks page on this PR to verify everything works as expected?
|
The installer seems to work fine (I had another problem, but I think it's not related and just a windows bug.) |
|
Ok. Probably we need to make the label a bit bigger. It should be possible to do this here: Line 350 in f9b8973 |
|
Can you edit this line and check if e.g. 13u instead of 12u in this line works better? |
|
Can I check that through this pull request? Or through another one? - This one is about translation I guess. |
Yes, another PR (with your changes) would be better |
|
But until this pull request is not merged and I send a change to my fork it will automatically land exactly here I suppose. |
|
If you change it on master, yes it will add the commit here. If you select to create a new branch via the GitHub web UI, you should be able to create a new PR. |
|
@SeeLook Could you please rebase? I guess one of the other translations added a conflict in |
|
Please give me a hint how can I do that rebase. |
I think it can be done in the Github UI. Do you see a Resolve conflicts button? This should lead to the right place. It will open an editor where you would have to edit the conflicting file ( You can also do the same using the git command line, but it'd be some more steps. Can you try?
Sounds good, thanks! |

I dared to translate that.
Probably it is not enough to make it work with all NSIS structure and the installer
but from translation angle it should be sufficient.
Let me know if I can do more.