Skip to content

Comments

Update translation_fr_FR.ts for 3.7.0 Release#1113

Merged
hoffie merged 3 commits intojamulussoftware:masterfrom
jujudusud:patch-1
Feb 26, 2021
Merged

Update translation_fr_FR.ts for 3.7.0 Release#1113
hoffie merged 3 commits intojamulussoftware:masterfrom
jujudusud:patch-1

Conversation

@jujudusud
Copy link
Member

Adding FR translation for new texts for Release 3.7.0

Adding FR translation for new texts for Release 3.7.0
@ann0see
Copy link
Member

ann0see commented Feb 25, 2021

@jujudusud Thanks for your first PR! Great for updating the french translation. I'll look into it shortly. In the meantime, you can add yourself as translation contributor in the src/util.cpp file.

@ann0see ann0see self-assigned this Feb 25, 2021
@jujudusud
Copy link
Member Author

Hi @ann0see , I have done this translation in order to have the 3.7.0 release totaly in french :-)
I think Olivier can't for now.

@ann0see ann0see mentioned this pull request Feb 25, 2021
39 tasks
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thanks for the information and that you take over. See my comment and the check list:

  • Listed in the Contributors UI (you should add yourself to the file I mentioned) via #1128
  • Changes look consistent
  • No untranslated strings (see my coments)

@hoffie hoffie added this to the Release 3.7.0 milestone Feb 25, 2021
Delete "undefined" translation label
@jujudusud jujudusud requested a review from ann0see February 25, 2021 23:03
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Some minor comments regarding spacing and we should be good to go! :)

@ann0see
Copy link
Member

ann0see commented Feb 26, 2021

If you have time, you can also add a french translation to the installer if you want. See #1124 as an example.

Taking into account of @hoffie comments.
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks.

@ann0see ann0see requested a review from hoffie February 26, 2021 16:24
@ann0see
Copy link
Member

ann0see commented Feb 26, 2021

You should still add yourself to the contributing file ;-).

@jujudusud
Copy link
Member Author

You should still add yourself to the contributing file ;-).

Done at #1128

Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hoffie hoffie merged commit e4ae013 into jamulussoftware:master Feb 26, 2021
@jujudusud jujudusud deleted the patch-1 branch April 20, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

3 participants