Skip to content

Comments

IT Update for 3.7.0#1112

Merged
hoffie merged 3 commits intojamulussoftware:masterfrom
dzpex:master
Feb 26, 2021
Merged

IT Update for 3.7.0#1112
hoffie merged 3 commits intojamulussoftware:masterfrom
dzpex:master

Conversation

@dzpex
Copy link
Contributor

@dzpex dzpex commented Feb 25, 2021

No description provided.

@softins softins added this to the Release 3.7.0 milestone Feb 25, 2021
@ann0see ann0see self-assigned this Feb 25, 2021
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just added the official checklist here. There's also another file (.qm) which is empty, but I think that's no problem

  • Listed in the Contributors UI
    "<p>Giuseppe Sapienza (<a href=\"https://github.com/dzpex\">dzpex</a>)</p>"
  • Changes look consistent
  • No untranslated strings

@ann0see ann0see mentioned this pull request Feb 25, 2021
39 tasks
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. Missed a typo

<location filename="../../clientsettingsdlg.cpp" line="178"/>
<source>This opens the driver settings of your sound card. Some drivers allow you to change buffer settings, others like ASIO4ALL let you choose input or outputs of your device(s). More information can be found on jamulus.io.</source>
<translation type="unfinished"></translation>
<translation>Aprirà il software di gestione della scheda audio. I driver danno la possibilità di modificare i valori del buffer delay e in alcuni casi, come con gli ASIO$ALL di scegliere gli input e gli output da usare. Altre informazioni sono disponibili sul sito jamulus.io.</translation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. sorry: missed this line you typed ASIO$ALL, but I think it should be ASIO4ALL here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it's a mistake... i resend the correct file

Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will approve once the comment by @ann0see is addressed. :)

@ann0see
Copy link
Member

ann0see commented Feb 25, 2021

By the way @dzpex you can now open a PR with your changes to the translate3_7_0 branch on the website repo.

@dzpex
Copy link
Contributor Author

dzpex commented Feb 26, 2021

Thanks for your job!!

@ann0see
Copy link
Member

ann0see commented Feb 26, 2021

Thanks for your job too! BTW: your last commit has an unfinished attribute. Could you please remove it?

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thanks!

Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hoffie hoffie merged commit 2c90392 into jamulussoftware:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

4 participants