Skip to content

Comments

Prepare Swedish translation för V370#1106

Merged
pljones merged 1 commit intojamulussoftware:masterfrom
genesisproject2020:master
Feb 24, 2021
Merged

Prepare Swedish translation för V370#1106
pljones merged 1 commit intojamulussoftware:masterfrom
genesisproject2020:master

Conversation

@genesisproject2020
Copy link
Contributor

V370

@ann0see
Copy link
Member

ann0see commented Feb 24, 2021

Thanks @genesisproject2020 There's still one open question. See my review below.

  • Listed in the Contributors UI window yes
  • Changes look consistent
  • No untranslated strings

@ann0see ann0see self-requested a review February 24, 2021 18:13
@ann0see ann0see self-assigned this Feb 24, 2021
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks great! Have a look at my comments.

<location filename="../../aboutdlgbase.ui" line="72"/>
<source>Copyright (C) 2005-2021 The Jamulus Development Team</source>
<translation type="unfinished"></translation>
<translation>Upphovsrätt (C) 2005-2021 The Jamulus Development Team</translation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still an open discussion if this should be translated: #1097 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a correct translation but let's see what's the decision will be.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just leave it up to the translators. So you can decide what you want to do.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've agreed to leave it to translators, I'm going to merge.

@hoffie hoffie mentioned this pull request Feb 24, 2021
39 tasks
@pljones pljones merged commit 742c839 into jamulussoftware:master Feb 24, 2021
@pljones pljones added this to the Release 3.7.0 milestone Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

4 participants