Skip to content

Comments

Update Slovak translation#1104

Merged
pljones merged 2 commits intojamulussoftware:masterfrom
jose1711:sk_tr
Feb 24, 2021
Merged

Update Slovak translation#1104
pljones merged 2 commits intojamulussoftware:masterfrom
jose1711:sk_tr

Conversation

@jose1711
Copy link
Contributor

No description provided.

Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! I don't know Slovak, but I have checked spacing, punctuation, etc. and it seems fine.

One question: I notice that there are still some untranslated strings. I guess it will take some time for those to be translated as well.

Are you planning to translate them as well?

I'm approving the PR for now anyway as getting this in is already a great thing to have! :)

Example:

    <message>
        <location filename="../../soundbase.cpp" line="197"/>
        <source> could not be started because of audio interface issues.</source>
        <translation type="unfinished"></translation>
    </message>

@jamulussoftware/maindevelopers I guess we should check all such PRs for stuff which still needs translating. Hadn't done that in the previous PRs, but will do now. grep unfinished -5 src/res/translation/translation_$TRANSLTION*.ts helps.

  • Listed in the Contributors UI window
  • Changes look consistent
  • No untranslated strings

<location filename="../../util.cpp" line="510"/>
<source>Slovak</source>
<translation type="unfinished"></translation>
<translation>slovenčina</translation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be capitalised? Slovenčina

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoffie hoffie mentioned this pull request Feb 24, 2021
39 tasks
@jose1711
Copy link
Contributor Author

Thanks for your work! I don't know Slovak, but I have checked spacing, punctuation, etc. and it seems fine.

One question: I notice that there are still some untranslated strings. I guess it will take some time for those to be translated as well.

Are you planning to translate them as well?

Thank you. Yes, eventually. This commit was mainly stuff I've been working on and somehow forgot about it. I can't really predict when I have time to resume so pushing what I currently have.

@ann0see ann0see added this to the Release 3.7.0 milestone Feb 24, 2021
@pljones pljones merged commit 8494633 into jamulussoftware:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

5 participants