Skip to content

Comments

Updated Polish translation for 3.7.0 release#1099

Merged
ann0see merged 5 commits intojamulussoftware:masterfrom
SeeLook:master
Feb 25, 2021
Merged

Updated Polish translation for 3.7.0 release#1099
ann0see merged 5 commits intojamulussoftware:masterfrom
SeeLook:master

Conversation

@SeeLook
Copy link
Contributor

@SeeLook SeeLook commented Feb 23, 2021

No description provided.

ann0see
ann0see approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Unfortunately I can't comment much here. Can you test if the translation is correct by checking the artifact?

@SeeLook
Copy link
Contributor Author

SeeLook commented Feb 23, 2021

Checked and even ironed out some kinks.

pljones
pljones reviewed Feb 23, 2021
View reviewed changes
hoffie
hoffie approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Looks good to me. I don't speak Polish but I have at least checked punctuation, spacing and technical words.

I wonder why there is any empty src/res/translation/translation_pl_PL.qm file. Not sure if it causes any problems, I guess it will be overwritten later anyway.

src/res/translation/translation_pl_PL.ts
<location filename="../../aboutdlgbase.ui" line="72"/>
<source>Copyright (C) 2005-2021 The Jamulus Development Team</source>
<translation type="unfinished"></translation>
<translation>Copyright (C) 2005-2021 Zespół programistów Jamulus-a</translation>
Copy link
Member

@hoffie hoffie Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should wait with the merge depending on what we settle on in #1097 (comment)

Copy link
Member

@ann0see ann0see Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can just leave it like that. If the qm file isn't something we need to worry about I'd say this is ready to be merged then.

@hoffie
Copy link
Member

hoffie commented Feb 24, 2021 •
edited
Loading

Just checked: There don't seem to be any untranslated things left, which is good! :)

  • Listed in the Contributors UI window
  • Changes look consistent
  • No untranslated strings

@SeeLook
Copy link
Contributor Author

SeeLook commented Feb 24, 2021

That was the plan :)

@hoffie hoffie mentioned this pull request Feb 24, 2021
Closed
39 tasks
@ann0see ann0see added this to the Release 3.7.0 milestone Feb 24, 2021
@pljones
Copy link
Collaborator

pljones commented Feb 25, 2021

I wonder why there is any empty src/res/translation/translation_pl_PL.qm file. Not sure if it causes any problems, I guess it will be overwritten later anyway.

I don't remember the process -- @softins can you comment?

@softins
Copy link
Member

softins commented Feb 25, 2021 •
edited
Loading

Yes, no need to worry about the .qm files. Once all the .ts files are in and merged, one of us (I'm happy to) can just run lrelease Jamulus.pro, which will generate all the .qm files, and then after that we check them in. I think really they ought to be generated by the makefile, but that doesn't happen now. I tried deleting the qms and runnng make, and it failed, complaining it couldn't find them.

@jerogee jerogee mentioned this pull request Feb 25, 2021
Closed
@ann0see ann0see merged commit bf10802 into jamulussoftware:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pljones pljones pljones left review comments

@ann0see ann0see ann0see approved these changes

@hoffie hoffie hoffie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Tracking
Status: Triage

Milestone

Release 3.7.0

Development

Successfully merging this pull request may close these issues.

5 participants

@SeeLook @hoffie @pljones @softins @ann0see