V370 german by rolamos · Pull Request #1097 · jamulussoftware/jamulus

rolamos · 2021-02-23T18:03:08Z

PR for German Translation

Added German Translations (Roland Moschel)

pljones · 2021-02-23T18:04:55Z

src/res/translation/translation_de_DE.ts

        <location filename="../../aboutdlgbase.ui" line="72"/>
        <source>Copyright (C) 2005-2021 The Jamulus Development Team</source>
-        <translation type="unfinished"></translation>
+        <translatorcomment>Could also stay in english language, since this is also common in german</translatorcomment>


What is the philosophy for this used in the other translation files? Is there a common approach?

I think this is just a comment and will not be shown in the UI?

I guess the question with this item is whether "The Jamulus Development Team" is effectively a name that doesn't need translating, or a description that does. It's a new topic because it just used to say Volker Fischer (and others).

Yes, I should have realised that! :)

I'm tempted to say leave the copyright string untranslated unless there's a legal reason to transform it for compliance. That would still not need to change Jamulus Development Team, if we've adopted that as the copyright holder.

(I am not a lawyer....)

I translated it into german, but IMHO this is something , which one could leave completely in english since it is a kind of common standard ? Isn´t it ?

I'd also say: Leave it untranslated.

I think this is just a comment and will not be shown in the UI?

The source will be shown in the UI (if there is no translation), but the translatorcomment will not, of course.

I don't have any strong opinion on this. So I don't care if it's translated or not.

ann0see

Thank you very much for your first translation! There are some minor points (I added some comments).

ann0see · 2021-02-23T18:23:08Z

src/res/translation/translation_de_DE.ts

        <location filename="../../aboutdlgbase.ui" line="72"/>
        <source>Copyright (C) 2005-2021 The Jamulus Development Team</source>
-        <translation type="unfinished"></translation>
+        <translatorcomment>Could also stay in english language, since this is also common in german</translatorcomment>


I think this is just a comment and will not be shown in the UI?

src/res/translation/translation_de_DE.ts

hoffie

@rolamos Thanks for your work, this is great! I have added some comments and I hope I don't sound too picky... :)

src/res/translation/translation_de_DE.ts

hoffie · 2021-02-24T11:09:20Z

Just checked: There don't seem to be any untranslated things left, which is good! :)

Listed in the Contributors UI window via Add rolamos to translators list. #1103
Changes look consistent
No untranslated strings

ann0see

Thanks @rolamos for your work! After the suggestions of hoffie are discussed, I think, this is ready.

Co-authored-by: Christian Hoffmann <[email protected]>

ann0see

Great! I‘ll approve this now. Thanks for your work. Have a look at my hint, but I don’t think it’s blocking.

ann0see · 2021-02-25T07:11:13Z

src/res/translation/translation_de_DE.ts

        <location filename="../../clientsettingsdlg.cpp" line="150"/>
        <source>Some sound card drivers do not allow the buffer delay to be changed from within the application. In this case the buffer delay setting is disabled and has to be changed using the sound card driver. On Windows, press the ASIO Device Settings button to open the driver settings panel. On Linux, use the Jack configuration tool to change the buffer size.</source>
-        <translation type="unfinished"></translation>
+        <translation>Einige Audiotreiber verhindern das Umstellen der Puffer-Verzögerung aus einer Anwendung heraus. In diesem Falle wird die Einstellung der Puffer-Verzögerung in Jamulus deaktiviert und sollte daher im Treiber des Audiointerfaces selbst geändert werden. Unter Windows kann man diese Einstellung über den Knopf &quot;ASIO-Geräte-Einstellungen&quot; erreichen. Unter Linux sollte man das Jack-Configuration-Tool verwenden, um die Puffergrösse zu ändern.</translation>


Just a small hint here (not sure how this is handled in other translations): usually the name „Jamulus“ is not part of the translation, rather defined by the code so that it’s easy to change it if someone wanted to rename the application.

pljones

My outstanding comments were more about the English. So not appropriate for this PR.

pljones · 2021-02-23T18:11:58Z

src/res/translation/translation_de_DE.ts

    </message>
    <message>
        <location filename="../../clientsettingsdlg.cpp" line="183"/>
        <source>Opens the driver settings. Note: </source>


Not your issue.

Lines 183 to 185 look wrong... It's probably something I've not considered until reviewing the translations... Would it not be easier for a translator to have the full text with substitutions (so, QString ( tr ( "Hello, %1" ) ).arg( getName() )..., giving the context)? Here there are three pieces, one starting with a measurement unit.

#1097 (comment)
That one was a "real hit" for the issue on those lines.

pljones · 2021-02-23T18:33:34Z

src/res/translation/translation_de_DE.ts

        <location filename="../../aboutdlgbase.ui" line="72"/>
        <source>Copyright (C) 2005-2021 The Jamulus Development Team</source>
-        <translation type="unfinished"></translation>
+        <translatorcomment>Could also stay in english language, since this is also common in german</translatorcomment>


Yes, I should have realised that! :)

I'm tempted to say leave the copyright string untranslated unless there's a legal reason to transform it for compliance. That would still not need to change Jamulus Development Team, if we've adopted that as the copyright holder.

(I am not a lawyer....)

hoffie

Thanks!

rolamos added 2 commits February 23, 2021 18:59

Update translation_de_DE.ts

29427c2

Added German Translations (Roland Moschel)

Update translation_de_DE.ts

0d93d26

pljones reviewed Feb 23, 2021

View reviewed changes

softins requested a review from ann0see February 23, 2021 18:28

ann0see requested changes Feb 23, 2021

View reviewed changes

ann0see requested a review from hoffie February 23, 2021 18:31

ann0see added the translation label Feb 23, 2021

Update translation_de_DE.ts

c2a9bf3

hoffie requested changes Feb 23, 2021

View reviewed changes

hoffie mentioned this pull request Feb 24, 2021

Updated Polish translation for 3.7.0 release #1099

Merged

pljones mentioned this pull request Feb 24, 2021

Prepare release 3.7.0 #1086

Closed

39 tasks

ann0see added this to the Release 3.7.0 milestone Feb 24, 2021

ann0see self-requested a review February 24, 2021 17:54

ann0see reviewed Feb 24, 2021

View reviewed changes

ann0see mentioned this pull request Feb 24, 2021

Prepare Swedish translation för V370 #1106

Merged

rolamos and others added 5 commits February 25, 2021 01:54

Update src/res/translation/translation_de_DE.ts

b6589ed

Co-authored-by: Christian Hoffmann <[email protected]>

Update src/res/translation/translation_de_DE.ts

7b4fc11

Co-authored-by: Christian Hoffmann <[email protected]>

Update src/res/translation/translation_de_DE.ts

2fe6b15

Co-authored-by: Christian Hoffmann <[email protected]>

Update src/res/translation/translation_de_DE.ts

555c523

Co-authored-by: Christian Hoffmann <[email protected]>

Update src/res/translation/translation_de_DE.ts

add2d88

Co-authored-by: Christian Hoffmann <[email protected]>

ann0see approved these changes Feb 25, 2021

View reviewed changes

ann0see requested a review from hoffie February 25, 2021 16:52

pljones approved these changes Feb 25, 2021

View reviewed changes

hoffie mentioned this pull request Feb 25, 2021

Translations: Use substitutions instead of concatenations #1114

Closed

hoffie approved these changes Feb 25, 2021

View reviewed changes

hoffie merged commit 04bba26 into jamulussoftware:master Feb 25, 2021

Comments

Conversation

rolamos commented Feb 23, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

softins Feb 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ann0see left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hoffie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hoffie commented Feb 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ann0see left a comment

Choose a reason for hiding this comment

Uh oh!

ann0see left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pljones left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoffie left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

softins Feb 23, 2021 •

edited

Loading

hoffie commented Feb 24, 2021 •

edited

Loading