Skip to content

Windows installer doesn't build correctly in a path with spaces #864

@ann0see

Description

@ann0see

#841 Sorry for opening another installer issue.

This is low priority at the moment.

If you build the Windows Installer in a path containing spaces, the resulting installer creates folders in $INSTDIR which relate to the folder where the installer was built. So e.g. if your build is in "C:\Users\My User\jamulus", the installer creates a folder in $INSTDIR which look like this: "$INSTDIR\C\Users\My"

I think the problem is related to quoting in CMD. At the time of writing this, the error can be traced back to this + a few lines after: https://github.com/corrados/jamulus/blob/1ce54ba0566c9064939f88ea13f35999cb97ae61/windows/installer.nsi#L138
see commit 6aa10d6 if the line changed.

Maybe we could execute this line in PowerShell which allows better quoting?

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions