Skip to content

Use a different approach to get external IP address #633

@atsampson

Description

@atsampson

From discussion in #572...

NetworkUtil::GetLocalAddress is used by CServerListManager's constructor to provide an idea of the server's own address for the first entry in the server list. Currently it works by opening a TCP connection to Google's public DNS server and using Qt's wrapper for getsockname to get the local end's address, which isn't ideal for privacy reasons.

We could rework this to use a connect()-ed UDP socket, which would achieve the same effect without actually sending any packets (on Linux/FreeBSD at least; I don't know if this works on Windows/MacOS). Or we might be able to get the address from one of the Jamulus server's existing sockets when replying to a server list request.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions