Skip to content

Do not show ASIO Device settings and open ASIO settings on JACK version of Jamulus #2186

@ann0see

Description

@ann0see

Documenting for future fixing. In theory this is a good first issue ;-). However the description is for the team.

Currently we still show the ASIO device settings button (probably somewhere in settings) and the open ASIO settings button in soundbase.cpp even if we compile the JACK version on windows. We should not use #ifdef _WIN32 in these files.

See:

Is this defined if we're running JACK on Windows? If so, it's the wrong symbol.

Originally posted by @pljones in #2168 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions