Skip to content

Commit ac5766e

Browse files
committed
test(driver-mxc): avoid unsafe env mutation in resolve_agent_env test
Replace std::env::{set,remove}_var (unsafe + racy under parallel test execution in edition 2024) with a read-only PATH lookup. Preserves all three behaviors under test and drops the #[allow(unsafe_code)].
1 parent 94d9e82 commit ac5766e

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

‎crates/openshell-driver-mxc/src/driver.rs‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -921,7 +921,6 @@ mod lifecycle_tests {
921921
}
922922

923923
#[test]
924-
#[allow(unsafe_code)] // std::env::{set,remove}_var are unsafe under edition 2024
925924
fn resolve_agent_env_passthrough_and_host_lookup() {
926925
// Literal KEY=VALUE passes through verbatim.
927926
assert_eq!(
@@ -933,11 +932,13 @@ mod lifecycle_tests {
933932
assert!(resolve_agent_env(&["OPENSHELL_TEST_DEFINITELY_UNSET_VAR".into()]).is_empty());
934933

935934
// Bare KEY for a set host var resolves to KEY=value from the host env.
936-
let var = "OPENSHELL_TEST_AGENT_ENV_KEY";
937-
unsafe { std::env::set_var(var, "secret-123") };
935+
// Use PATH (guaranteed present) read-only, so the test never mutates the
936+
// process environment (set_var/remove_var are unsafe + racy under
937+
// parallel test execution in edition 2024).
938+
let var = "PATH";
939+
let expected = std::env::var(var).expect("PATH must be set in test environment");
938940
let resolved = resolve_agent_env(&[var.to_string()]);
939-
unsafe { std::env::remove_var(var) };
940-
assert_eq!(resolved, vec![format!("{var}=secret-123")]);
941+
assert_eq!(resolved, vec![format!("{var}={expected}")]);
941942
}
942943

943944
#[test]

0 commit comments

Comments
 (0)