Repository navigation
MCP: upgrade the 17 bare-object outputSchemas to typed (lib-type derives + typed cores + bespoke output structs) #2203
Description
From the #2125 lane. tools/list now publishes an outputSchema for all 34 tools, but 17 are honest-but-loose bare-object schemas because their outputs aren't derivable types today:
- DEEP-blocked (a):
impact/review/ci/planneedschemars::JsonSchemaon lib types (src/impact/types.rs, src/review.rs, src/ci.rs, src/plan.rs, src/scout.rs);ImpactCoreOutputhas a hand-writtento_value()a derive wouldn't reproduce → needs a manual JsonSchema impl. - Untyped cores (b):
scout/onboard/task/context/blame/read/impact-diff/healthreturnserde_json::Value(or lib types likeHealthReport) — cores need typed outputs first. - Bespoke shapes (c):
search({results,query,total}) + the 3 notes mutators (NoteMutationOutput+ injectedreindex_deferred) want small dedicated output structs.
Each row-flip is then localized (object → typed(T) in command_output_map!). Related sub-item: the typed schemas with Vec<serde_json::Value> fields (gather.chunks, similar.results, trace.candidates, KindFallbackOutput.definitions) are loose "any" arrays until the chunk/SearchResult shape is typed — same follow-up.
Activity
feat(mcp): type 13 of 17 bare-object outputSchemas (#2209)
jamie8johnson commentedon Jul 3, 2026
Part 1 landed (PR #2209): 13 of 17 typed. Outcome table:
to_value's real wire shape (oneOf function/fallback, injectedkind), shape-truth-pinnedcontent/injection_flags/token_countonto serialized results — a manual schema would duplicate that contract and driftRemaining tail (this issue stays open for):
contextadditionally needs an untagged 3-shape (compact/summary/full).Vec<Value>"any" arrays (search.results, gather.chunks, similar.results, trace.candidates, KindFallbackOutput.definitions, scout/onboard nested chunks) — needs schema-only descriptor types for the per-result/chunk projections.No wire shape changed in part 1 (byte-identity held by the noise guard + envelope pins + parity suites).
feat(mcp): type the outputSchema tail — composites + inner arrays (cl…