Change deadline to use internal atomics#2
Merged
Conversation
Collaborator
Author
|
Seems to work like expected! |
jamesmunns
approved these changes
Jul 15, 2025
Owner
jamesmunns
left a comment
jamesmunns
left a comment
There was a problem hiding this comment.
Looks fine to me, thank you!
jamesmunns
pushed a commit
that referenced
this pull request
Dec 4, 2025
Avoid generating update events when changing timer period, #2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo: testing