Skip to content

Commit 01ee501

Browse files
committed
feat(review): unify PR and Git reviews across desktop and mobile
All feature implementations were reviewed and approved through desktop and mobile screenshots. - PR overview: combine description, checks, and activity; keep Overview, Code, and Guide tabs. - Guides: generate on demand and organize changes into navigable chapters; generated files have separate chapters. - Review progress: review individual files or whole chapters. Marking a chapter viewed/unviewed marks every member the same way. File status syncs both ways with GitHub. - Renames: show the old and new path names inline, highlighting changed text; retain full-path copying. - Git diff headers: remove the redundant viewed checkbox from non-PR Git diffs; keep explicit file and hunk stage/unstage actions. - Files and Git: Files is the combined changed-file tree. Git uses compact, collapsible Staged Changes and Changes trees, a unique changed-file badge, and ellipsized paths. Desktop panel resizes; mobile uses a drawer matching the existing Files-tree density. - Staging: inline hunk actions on desktop and mobile; stage/unstage files, folders, or whole sections. Revert requires confirmation. - Commits: commit staged content from the Git panel. The attached dropdown executes Commit, Amend, or Commit & Push immediately. Blank messages generate from staged content; the staged-only sparkle generates an editable preview. - Merging: only admins with merge permission can bypass unmet requirements, using a checkbox confirmation. Passing requirements use normal merge confirmation. Remove Explain this PR and Write guide from the dropdown; guide generation stays in Guide. - Comments: show threaded replies with dividers and a fully visible composer. Resolve is a header checkmark; Unresolve stays in comment actions. Resolved threads collapse to an expandable count-and-participant summary. - Mobile reactions: Add reaction has its own icon button and picker. Emoji choices do not appear in the comment actions menu. - Mobile composers: compact comment field with an attached paperclip/send toolbar and content-sized sheets. Remove the tall sheet and detached center paperclip. - Attachments: use a paperclip, and file drops on desktop, to upload into comment text at the cursor. Hosted links paste directly into text; remove the separate link form. - Line comments: use GitHub mobile tap/long-press range mechanics and a clear Comment action; support single lines and ranges. Pending comments show a clock badge. Copy link returns the actual private GitHub pending-comment permalink; discard and submission retain the same saved-comment identity. - Mobile commit picker: use a compact desktop-like picker with ellipsized rows and a clear selected range; replace the oversized native menu. - Commit ranges: select contiguous commits, return to All commits, or use Since last reviewed when available. Private pending reviews do not count as completed reviews. - Unresolved comments: counts and the files-with-comments filter refer only to unresolved threads. Viewed checkmarks and counts appear together. Code has labeled Expand/Collapse all controls; desktop header counts and viewed states align. - Viewing preferences: start with the existing Settings values and persist changes through the same store. Desktop Unified/Split uses a visual tab group. Guide exposes only applicable diff controls. - File groups: use the Guide chapter presentation for Implementation, Tests, and Generated groups in Code. Hide empty chapters; chapter review actions cover all member files, including hidden files. - File navigation: compact, expandable, folder-first alphabetical trees with clear status and ellipsized long paths. - Folder progress: offer only useful Mark viewed/unviewed actions; fully viewed folders omit Mark viewed, fully unviewed folders omit Mark unviewed. - Review position: sending a prompt preserves scroll position and expanded files. - Shared code: share web/desktop/mobile logic wherever practical. Removed from this branch: - Latest-only handoffs and same-provider account monograms. - Direct file editing, find/select-next shortcuts, unsaved indicators, and Save/Discard/Cancel. - Custom-only keybinding filtering. - Restored last-thread worktree cleanup prompts. - Historical open-PR and closed-PR sections of the Doc. - Folder-wide diff viewing and the flat-list option. Validation: 1282 focused tests, nine package typechecks, formatting, and scoped lint passed. Android native verification unavailable on the build host.
1 parent 67c0fc0 commit 01ee501

155 files changed

Lines changed: 14147 additions & 2641 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎apps/mobile/modules/t3-review-diff/android/src/main/java/expo/modules/t3reviewdiff/T3ReviewDiffModule.kt‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,15 @@ class T3ReviewDiffModule : Module() {
2323
Prop("selectedRowIdsJson") { view: T3ReviewDiffView, selectedRowIdsJson: String ->
2424
view.setSelectedRowIdsJson(selectedRowIdsJson)
2525
}
26+
Prop("enableLineRangeSelection") { view: T3ReviewDiffView, enabled: Boolean ->
27+
view.setEnableLineRangeSelection(enabled)
28+
}
29+
Prop("showViewedCheckbox") { view: T3ReviewDiffView, shown: Boolean ->
30+
view.setShowViewedCheckbox(shown)
31+
}
32+
Prop("viewedCheckboxEnabled") { view: T3ReviewDiffView, enabled: Boolean ->
33+
view.setViewedCheckboxEnabled(enabled)
34+
}
2635
Prop("collapsedCommentIdsJson") { view: T3ReviewDiffView, collapsedCommentIdsJson: String ->
2736
view.setCollapsedCommentIdsJson(collapsedCommentIdsJson)
2837
}
@@ -56,6 +65,8 @@ class T3ReviewDiffModule : Module() {
5665
"onToggleFile",
5766
"onToggleViewedFile",
5867
"onPressLine",
68+
"onSelectLineRange",
69+
"onPressHunk",
5970
"onToggleComment",
6071
)
6172

0 commit comments

Comments
 (0)