Skip to content

Centralize and refactor helpers#44

Merged
jakekaplan merged 3 commits intomainfrom
simplify-consolidate
Jan 22, 2026
Merged

Centralize and refactor helpers#44
jakekaplan merged 3 commits intomainfrom
simplify-consolidate

Conversation

@jakekaplan
Copy link
Owner

  • Centralized config defaults and config I/O/threshold parsing, plus shared persistence for baseline/tighten/relax.
  • Unified report generation for text/JSON, added shared change row formatting and width calculation.
  • Simplified core logic: reverse rule matching, "helperized" report finding creation, and streamlined cache/outcome handling.
  • Clarified naming (relative_path_for_match, scan_violations_with_threshold, write_change_row, max_formatted_width)
    and aligned call sites/test

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 98.83721% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.51%. Comparing base (c068ccc) to head (9ba9fa0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/loq_cli/src/baseline.rs 96.72% 2 Missing ⚠️
crates/loq_fs/src/lib.rs 96.72% 2 Missing ⚠️
crates/loq_cli/src/relax.rs 97.22% 1 Missing ⚠️
crates/loq_cli/src/tighten.rs 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   98.62%   98.51%   -0.11%     
==========================================
  Files          21       21              
  Lines        3209     3175      -34     
==========================================
- Hits         3165     3128      -37     
- Misses         44       47       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 9ba9fa0 Previous: c068ccc Ratio
cpython 0.052933159480000005 seconds (± 0.0016) 0.053187184080000005 seconds (± 0.0034) 1.00
airflow 0.14641508838 seconds (± 0.0013) 0.14249884328 seconds (± 0.0006) 1.03
prefect 0.062301936880000006 seconds (± 0.0008) 0.061034503080000004 seconds (± 0.0009) 1.02
ruff 0.12973529488 seconds (± 0.0012) 0.12681795068 seconds (± 0.0013) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

@jakekaplan jakekaplan merged commit 34aa2e2 into main Jan 22, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant