Skip to content

fix sorting, updated output#43

Merged
jakekaplan merged 1 commit intomainfrom
fix-sorting
Jan 22, 2026
Merged

fix sorting, updated output#43
jakekaplan merged 1 commit intomainfrom
fix-sorting

Conversation

@jakekaplan
Copy link
Owner

@jakekaplan jakekaplan commented Jan 22, 2026

  • Docs: README refreshed to match baseline/tighten/relax behavior and the new relax default
    buffer.
  • Behavior:
    • tighten no longer adds rules for new violations; only tightens/removes existing exact‑path
      limits.
    • relax now adds .loq_cache to an existing .gitignore when it creates loq.toml.
    • relax default buffer is now 0.
  • Output/UX:
    • init prints ✔ Created loq.toml.
    • Standardized “✔ No changes needed” for baseline/tighten/relax.
    • Summary wording uses “files” instead of “rules”.
    • tighten now prints per‑file from -> to lines (aligned, sorted smallest→largest by new
      limit) plus checkmarked summaries.
    • relax keeps per‑file lines, aligned columns, sorted smallest→largest by new limit, and
      checkmarked summary.
    • baseline now prints per‑file change lines with symbols (+ added, ~ updated, - removed),
      where added uses - -> limit and removed uses limit -> -, sorted smallest→largest by final
      limit, and checkmarked summaries.
  • MSRV fixes: removed const fn usage that tripped clippy on 1.75.
  • Tests: updated and added coverage for the new output formats and behaviors across baseline/
    relax/tighten; added unit tests for report formatting and empty cases.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: fed3cb7 Previous: b7558c5 Ratio
cpython 0.05171717819999999 seconds (± 0.0025) 0.05233699738000001 seconds (± 0.0035) 0.99
airflow 0.1426062421 seconds (± 0.0009) 0.14116825508000003 seconds (± 0.0008) 1.01
prefect 0.0591844106 seconds (± 0.0008) 0.05913586348000001 seconds (± 0.0007) 1.00
ruff 0.1257920801 seconds (± 0.0012) 0.12573178128 seconds (± 0.0013) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@jakekaplan jakekaplan merged commit c068ccc into main Jan 22, 2026
7 checks passed
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 99.30556% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.62%. Comparing base (b7558c5) to head (fed3cb7).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/loq_cli/src/baseline.rs 99.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   98.60%   98.62%   +0.02%     
==========================================
  Files          21       21              
  Lines        3158     3209      +51     
==========================================
+ Hits         3114     3165      +51     
  Misses         44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant