Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 573c795 | Previous: d600992 | Ratio |
|---|---|---|---|
cpython |
0.051887353059999995 seconds (± 0.0031) |
0.053392845060000006 seconds (± 0.0039) |
0.97 |
airflow |
0.14357618655999999 seconds (± 0.0006) |
0.14550399256 seconds (± 0.0018) |
0.99 |
prefect |
0.06001727946 seconds (± 0.0002) |
0.06112902856 seconds (± 0.0007) |
0.98 |
ruff |
0.12550913466 seconds (± 0.0011) |
0.12826274716 seconds (± 0.001) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 98.50% 98.51% +0.01%
==========================================
Files 19 19
Lines 2747 2769 +22
==========================================
+ Hits 2706 2728 +22
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were deviating from typical path-glob behavior: * was matching across directory separators
because we didn’t set
literal_separator(true)in globset. That made patterns likesrc/*.rsmatchsrc/nested/file.rs, which is unexpected for most users.Old behavior:
src/*.rsmatchedsrc/lib.rsandsrc/nested/lib.rs*.rsmatched files in subdirectories tooNew behavior:
*stays within a single path segment**is required to match across directories (e.g.src/**/*.rs)