Skip to content

clearer naming#31

Merged
jakekaplan merged 2 commits intomainfrom
rename-and-cleanup
Jan 18, 2026
Merged

clearer naming#31
jakekaplan merged 2 commits intomainfrom
rename-and-cleanup

Conversation

@jakekaplan
Copy link
Owner

  • Removed unused loq_core::format module and its export/doc mention from crates/loq_core/src/lib.rs.
  • Changed WalkError to a named-field struct { message: String }, added field doc, and updated all uses in
    CLI output/tests (crates/loq_fs/src/walk.rs, crates/loq_cli/src/output/mod.rs, crates/loq_cli/src/output/
    json.rs, crates/loq_cli/src/output/tests.rs, crates/loq_cli/src/check.rs).
  • Renamed is_excluded_explicit → should_skip_explicit_path, flipped the call site to avoid double-
    negatives, and simplified the helper to a single boolean expression (crates/loq_fs/src/walk.rs).
  • Renamed cache state: dirty → has_unsaved_changes, with_hash → empty_with_hash, updated tests and wording
    (crates/loq_fs/src/cache.rs).
  • Renamed relative_str → relative_path locals and relative_path_str → relative_path function, updated
    callers/tests (crates/loq_fs/src/lib.rs, crates/loq_fs/src/walk.rs, crates/loq_fs/src/tests.rs).
  • Renamed matched → last_matching_rule in decision logic for clarity (crates/loq_core/src/decide.rs).
  • Renamed extract_key → extract_unknown_key_name and updated test names (crates/loq_core/src/parse.rs).
  • Renamed BaselineStats::is_empty → has_no_changes and updated test name (crates/loq_cli/src/baseline.rs).

@jakekaplan jakekaplan changed the title cleanup clearer naming Jan 18, 2026
@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.50%. Comparing base (62d62c9) to head (7fedeb8).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   98.56%   98.50%   -0.06%     
==========================================
  Files          20       19       -1     
  Lines        3062     2747     -315     
==========================================
- Hits         3018     2706     -312     
+ Misses         44       41       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 7fedeb8 Previous: 62d62c9 Ratio
cpython 0.04205933744 seconds (± 0.0022) 0.050970545 seconds (± 0.0029) 0.83
airflow 0.11126562914 seconds (± 0.0041) 0.1427606369 seconds (± 0.0008) 0.78
prefect 0.04773482004 seconds (± 0.0009) 0.05971009890000001 seconds (± 0.0007) 0.80
ruff 0.09923539534000002 seconds (± 0.0011) 0.12560179440000002 seconds (± 0.0017) 0.79

This comment was automatically generated by workflow using github-action-benchmark.

@jakekaplan jakekaplan merged commit 56f1682 into main Jan 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant