Use a faster key, this one is twice as fast as the previous

jakebailey · jakebailey · commit bc7ad5d19349 · 2023-01-24T21:52:03.000-08:00
diff --git a/src/compiler/emitter.ts b/src/compiler/emitter.ts
@@ -1351,19 +1351,24 @@ export type ReusablePrinterOptions = Pick<PrinterOptions, "removeComments" | "ne
 
 /** @internal */
 export function createOrReusePrinter(o: ReusablePrinterOptions = {}) {
-    const key = `${keyBool(o.removeComments)}|${keyBool(o.neverAsciiEscape)}|${keyBool(o.omitTrailingSemicolon)}|${keyNum(o.module)}|${keyNum(o.target)}|${keyNum(o.newLine)}`;
+    const key = keyBool(o.removeComments)
+        + keyBool(o.neverAsciiEscape)
+        + keyBool(o.omitTrailingSemicolon)
+        + keyNum(o.module)
+        + keyNum(o.target)
+        + keyNum(o.newLine);
     let printer = printerCache.get(key);
     if (!printer) {
         printerCache.set(key, printer = createPrinter(o));
     }
     return printer;
 
     function keyBool(value: boolean | undefined): string {
-        return value === undefined ? "u" : value ? "1" : "0";
+        return value === undefined ? "u," : value ? "1," : "0,";
     }
 
     function keyNum(value: number | undefined): string {
-        return value === undefined ? "u" : `${value}`;
+        return value === undefined ? "u," : `${value},`;
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1351,19 +1351,24 @@ export type ReusablePrinterOptions = Pick<PrinterOptions, "removeComments" \| "ne`
`1351`	`1351`
`1352`	`1352`	`/** @internal */`
`1353`	`1353`	`export function createOrReusePrinter(o: ReusablePrinterOptions = {}) {`
`1354`		- const key = `${keyBool(o.removeComments)}\|${keyBool(o.neverAsciiEscape)}\|${keyBool(o.omitTrailingSemicolon)}\|${keyNum(o.module)}\|${keyNum(o.target)}\|${keyNum(o.newLine)}`;
	`1354`	`+ const key = keyBool(o.removeComments)`
	`1355`	`+ + keyBool(o.neverAsciiEscape)`
	`1356`	`+ + keyBool(o.omitTrailingSemicolon)`
	`1357`	`+ + keyNum(o.module)`
	`1358`	`+ + keyNum(o.target)`
	`1359`	`+ + keyNum(o.newLine);`
`1355`	`1360`	`let printer = printerCache.get(key);`
`1356`	`1361`	`if (!printer) {`
`1357`	`1362`	`printerCache.set(key, printer = createPrinter(o));`
`1358`	`1363`	`}`
`1359`	`1364`	`return printer;`
`1360`	`1365`
`1361`	`1366`	`function keyBool(value: boolean \| undefined): string {`
`1362`		`- return value === undefined ? "u" : value ? "1" : "0";`
	`1367`	`+ return value === undefined ? "u," : value ? "1," : "0,";`
`1363`	`1368`	`}`
`1364`	`1369`
`1365`	`1370`	`function keyNum(value: number \| undefined): string {`
`1366`		- return value === undefined ? "u" : `${value}`;
	`1371`	+ return value === undefined ? "u," : `${value},`;
`1367`	`1372`	`}`
`1368`	`1373`	`}`
`1369`	`1374`