I'm a bit torn on this. The list is even longer on https://html.spec.whatwg.org/multipage/webappapis.html#event-handlers-on-elements,-document-objects,-and-window-objects The list seems to be able to grow infinitely. There are currently in total more than 60 officially specified on* attributes for "all elements". The average Faces component has currently ~12 on* attributes, all dated from the HTML4 era. There are currently 23 Faces components thus each needing ~48 more attributes.

I'm not going to manually add more than 1000 attributes every time. This is not DRY and not long-term-maintainable.

Moreover, this doesn't really advocate "unobtrusive JavaScript" (https://en.wikipedia.org/wiki/Unobtrusive_JavaScript#Separation_of_behavior_from_markup).

I'm much more tempted to let Faces automatically treat every single attribute whose name starts with on as an automatic passthrough attribute if the associated event is known, rather than explicitly registering them as a copypasted <attribute> entry in some taglib XML file and as yet another getter/setter pair in some component class.

Internally, the existing HTML components and renderers already do absolutely nothing with them, they're all already just "passed through" without additional logic. We can at most maintain a (configureable?) list of all allowed event names per component type HtmlBody/UIOutput/UIInput/etc so that associated on* attributes may to be passed through, including unknown ones but at least log a dev stage warning on unknown ones. This way we can get rid of the associated getter/setter and taglib.xml boilerplate on them. If needed the renderer can still get/set the attribute via UIComponent#getAttributes().

For example HtmlBody has currently already this constant returned by its UIComponent#getEventNames():

    private static final Collection<String> EVENT_NAMES = Collections.unmodifiableCollection(
            Arrays.asList("click", "dblclick", "keydown", "keypress", "keyup", "load", "mousedown", "mousemove", "mouseout", "mouseover", "mouseup", "unload"));

This could be extended via some configuration file (context param?) and this could be consulted by the renderer while rendering an encountered on* attribute.

Enhance UIInput events with HTML5 like oninput #1507

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions