Skip to content
This repository was archived by the owner on Sep 13, 2022. It is now read-only.

Stop testing with Node <v10; upgrade tchannel->4.x#463

Merged
yurishkuro merged 6 commits intomasterfrom
remove-node-4
Apr 28, 2021
Merged

Stop testing with Node <v10; upgrade tchannel->4.x#463
yurishkuro merged 6 commits intomasterfrom
remove-node-4

Conversation

@yurishkuro
Copy link
Copy Markdown
Member

@yurishkuro yurishkuro commented Apr 24, 2021 •
edited
Loading

Which problem is this PR solving?

  • the CI no longer succeeds with Node 4
  • v10 is EOL in a few days

Short description of the changes

  • upgrade tchannel to 4.x to remove dependency on Node 0.10 (YAY!)
  • remove all Node versions earlier than v10; add versions 12, 14, 16
  • make Node v14 the primary
  • use official node/14-alpine base image for crossdock instead of hacky jaegertracing/xdock-node:docker-node-babel which has no source (see Replace docker-node-babel image that disappeared from Docker Hub #439)
    • turns out doing npm install is not that slow in Docker
  • clean-up GH actions and Make targets which had many unnecessary installs/uninstalls

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 24, 2021 •
edited
Loading

Codecov Report

Merging #463 (f912800) into master (4c739a2) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #463      +/-   ##
==========================================
+ Coverage   98.67%   98.72%   +0.04%     
==========================================
  Files          50       50              
  Lines        2035     2035              
  Branches      383      383              
==========================================
+ Hits         2008     2009       +1     
+ Misses         27       26       -1
Impacted Files Coverage Δ
src/reporters/remote_reporter.js 95.74% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c739a2...f912800. Read the comment docs.

@yurishkuro
Upgrade tchannel to 4.x, use node-alpine for crossdock
dc75fe0 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
cleanup
7671982 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
cleanup
f33c5ce 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro changed the title Stop testing with Node <v10, add latest versions Stop testing with Node <v10; add latest versions; upgrade tchannel->4.x Apr 25, 2021
@yurishkuro yurishkuro changed the title Stop testing with Node <v10; add latest versions; upgrade tchannel->4.x Stop testing with Node <v10; upgrade tchannel->4.x Apr 25, 2021
@yurishkuro
cleanup
f912800 
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro requested a review from vprithvi April 25, 2021 03:08
@yurishkuro yurishkuro mentioned this pull request Apr 25, 2021
Merged
@yurishkuro yurishkuro requested a review from jpkrohling April 26, 2021 16:41
@yurishkuro yurishkuro merged commit 6a6e3ea into master Apr 28, 2021
@yurishkuro yurishkuro deleted the remove-node-4 branch April 28, 2021 01:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vprithvi vprithvi Awaiting requested review from vprithvi

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yurishkuro