This repository was archived by the owner on Sep 13, 2022. It is now read-only.
Report HTTP errors when flushing spans#459
Merged
yurishkuro merged 2 commits intojaegertracing:masterfrom Apr 28, 2021
Merged
Conversation
Signed-off-by: Espen Hovlandsdal <[email protected]>
rexxars
force-pushed
the
feat/log-http-report-errors
branch
from
8df9c0b to
bca90f2
Compare
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 50 50
Lines 2035 2039 +4
Branches 383 384 +1
=======================================
+ Hits 2009 2013 +4
Misses 26 26
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes the issue where the server might respond with an error (4xx, 5xx) but no feedback is given to the developer that can help them diagnose the issue.
Resolves #458
Short description of the changes
logger.error()method, as well as providing the error to the flush callback function.