This repository was archived by the owner on Sep 13, 2022. It is now read-only.
Avoid mutation of user's tags#348
Merged
yurishkuro merged 2 commits intojaegertracing:masterfrom Apr 23, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 44 44
Lines 1717 1717
Branches 337 337
=======================================
Hits 1702 1702
Misses 15 15
Continue to review full report at Codecov.
|
Clone `options.tags` before assignment due to unnecessary mutations inside `Tracer` (jaegertracing#345) Signed-off-by: Fedorov Anton <[email protected]>
fapspirit
force-pushed
the
tag_mutation_fix
branch
from
50a31d0 to
5cb1d5b
Compare
Iuriy-Budnikov
pushed a commit
to agile-pm/jaeger-client-node
that referenced
this pull request
Sep 25, 2021
* chore: add plugin developer guide * chore: add a link to example plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anton Fedorov [email protected]
Which problem is this PR solving?
Short description of the changes
options.tagsbefore assignment due to unnecessary mutations insideTracer