This repository was archived by the owner on Sep 13, 2022. It is now read-only.
Support false values for the B3 Sampled header#346
Merged
black-adder merged 1 commit intojaegertracing:masterfrom Feb 19, 2019
sebnow:b3-sampled-deny
Merged
Support false values for the B3 Sampled header#346black-adder merged 1 commit intojaegertracing:masterfrom sebnow:b3-sampled-deny
black-adder merged 1 commit intojaegertracing:masterfrom
sebnow:b3-sampled-deny
Conversation
The sampling state headers can have three possible values; force sampling, deny sampling, and defer sampling decision. The B3 propagator only looks at the existence of the header, and thus always forces sampling, even when the value is falsy. Check that the value is true before setting the sampling flag. https://github.com/openzipkin/b3-propagation#sampling-state-1 Signed-off-by: Sebastian Nowicki <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
+ Coverage 99.12% 99.12% +<.01%
==========================================
Files 43 43
Lines 1714 1715 +1
Branches 336 337 +1
==========================================
+ Hits 1699 1700 +1
Misses 15 15
Continue to review full report at Codecov.
|
black-adder
approved these changes
Feb 19, 2019
Contributor
|
thanks! |
Iuriy-Budnikov
pushed a commit
to agile-pm/jaeger-client-node
that referenced
this pull request
Sep 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The sampling state headers can have three possible values; force sampling, deny sampling, and defer sampling decision. The B3 propagator only looks at the existence of the header, and thus always forces sampling, even when the value is falsy.
https://github.com/openzipkin/b3-propagation#sampling-state-1
Short description of the changes
Check that the value is true before setting the sampling flag.