This repository was archived by the owner on Sep 13, 2022. It is now read-only.
Transform IP from int32 representation to dot representation#340
Merged
black-adder merged 1 commit intojaegertracing:masterfrom Jan 29, 2019
societe-generale:switch_it_to_dot_representation
Merged
Transform IP from int32 representation to dot representation#340black-adder merged 1 commit intojaegertracing:masterfrom societe-generale:switch_it_to_dot_representation
black-adder merged 1 commit intojaegertracing:masterfrom
societe-generale:switch_it_to_dot_representation
Conversation
Etienne-Carriere
changed the title
black-adder
reviewed
Jan 29, 2019
Contributor
black-adder
left a comment
black-adder
left a comment
There was a problem hiding this comment.
can we remove Utils.ipToInt completely? I don't think we use it anywhere else
Contributor
Author
|
It is indeed no more used . |
Signed-off-by: Etienne Carriere <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
==========================================
+ Coverage 99.07% 99.12% +0.05%
==========================================
Files 43 43
Lines 1725 1713 -12
Branches 338 336 -2
==========================================
- Hits 1709 1698 -11
+ Misses 16 15 -1
Continue to review full report at Codecov.
|
1 task
mayurkale22
added a commit
to census-instrumentation/opencensus-node
that referenced
this pull request
May 28, 2019
mayurkale22
added a commit
to census-instrumentation/opencensus-node
that referenced
this pull request
May 28, 2019
mayurkale22
pushed a commit
to census-instrumentation/opencensus-node
that referenced
this pull request
May 29, 2019
* Update dependency jaeger-client to ~3.15.0 * Fix build - jaegertracing/jaeger-client-node#340
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?